From: <Andrei.Simion@microchip.com>
To: <arnd@arndb.de>, <brgl@bgdev.pl>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<claudiu.beznea@tuxon.dev>, <gregkh@linuxfoundation.org>
Cc: <linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 0/3] Read MAC address through NVMEM for sama7g5ek
Date: Fri, 28 Jun 2024 14:06:58 +0000 [thread overview]
Message-ID: <49a71ee7-b86b-4f44-b7b3-dc0a6433e1c3@microchip.com> (raw)
In-Reply-To: <58ec4d44-3393-4b0b-83c4-3f66b0e2de1e@app.fastmail.com>
On 28.06.2024 11:29, Arnd Bergmann wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Fri, Jun 28, 2024, at 10:01, Andrei Simion wrote:
>> This series proposes to add EEPROM support and reading MAC addresses
>> through NVMEM (via Devicetree) for sama7g5ek:
>> - Add in DT bindings document the EEPROM compatibles :
>> "microchip,24aa025e48" and "microchip,24aa025e64"
>> - Update to the driver to support "microchip,24aa025e48" and
>> "microchip,24aa025e64" and adjusting offset for those 24AA025E{48, 64}.
>> - Added the nodes in devicetree for eeproms where are stored EUI-48 MAC,
>> and update gmac nodes to read the MAC via devicetree through NVMEM.
>
> Can you add an explanation about what this is good for?
>
> Do you need to work around broken boot loaders that cannot be
> updated and that happen to store the MAC address in the EEPROM,
> or are you proposing this as a generic solution that board
> developers should actually use?
>
> As far as I can tell, even with this logic in place, users
> are better off just having the boot loader read the EEPROM
> and storing the MAC address in the in-memory dtb as we do
> on other platforms.
>
> Arnd
Our boot chain is ROM BOOT -> AT91Bootstrap -> U-Boot -> Linux Kernel. U-Boot is the stage where we set up the MAC address.
We can skip U-Boot and use the following boot chain ROM BOOT -> AT91Boostrap -> Linux Kernel.
This patch set is useful for this scenario and also for redundancy (if something related with NET/EEPROM fails in U-Boot).
Best Regards,
Andrei Simion
next prev parent reply other threads:[~2024-06-28 14:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 8:01 [PATCH v3 0/3] Read MAC address through NVMEM for sama7g5ek Andrei Simion
2024-06-28 8:01 ` [PATCH v3 1/3] eeprom: at24: avoid adjusting offset for 24AA025E{48, 64} Andrei Simion
2024-06-28 8:30 ` Bartosz Golaszewski
2024-06-28 14:17 ` Andrei.Simion
2024-06-28 14:46 ` Bartosz Golaszewski
2024-07-01 7:23 ` Andrei.Simion
2024-07-01 8:46 ` Bartosz Golaszewski
2024-07-01 10:20 ` Andrei.Simion
2024-07-01 11:16 ` Bartosz Golaszewski
2024-07-01 12:17 ` Andrei.Simion
2024-06-28 8:01 ` [PATCH v3 2/3] ARM: dts: at91: at91-sama7g5ek: add EEPROMs Andrei Simion
2024-06-28 8:01 ` [PATCH v3 3/3] dt-bindings: eeprom: at24: Add Microchip 24AA025E48/24AA025E64 Andrei Simion
2024-06-28 9:09 ` Conor Dooley
2024-07-01 14:37 ` Andrei.Simion
2024-07-01 14:47 ` Conor Dooley
2024-07-01 14:56 ` Andrei.Simion
2024-06-28 8:29 ` [PATCH v3 0/3] Read MAC address through NVMEM for sama7g5ek Arnd Bergmann
2024-06-28 14:06 ` Andrei.Simion [this message]
2024-06-28 14:25 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49a71ee7-b86b-4f44-b7b3-dc0a6433e1c3@microchip.com \
--to=andrei.simion@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).