From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D7D4C64EC4 for ; Thu, 9 Mar 2023 09:44:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231382AbjCIJo1 (ORCPT ); Thu, 9 Mar 2023 04:44:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231378AbjCIJn7 (ORCPT ); Thu, 9 Mar 2023 04:43:59 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 827C9D7C0C; Thu, 9 Mar 2023 01:43:45 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 20B8824E231; Thu, 9 Mar 2023 17:43:44 +0800 (CST) Received: from EXMBX172.cuchost.com (172.16.6.92) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 9 Mar 2023 17:43:44 +0800 Received: from [192.168.125.124] (183.27.96.115) by EXMBX172.cuchost.com (172.16.6.92) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 9 Mar 2023 17:43:43 +0800 Message-ID: <49ab1072-98ba-f364-9b66-68658566e732@starfivetech.com> Date: Thu, 9 Mar 2023 17:43:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v4 12/19] clk: starfive: Add StarFive JH7110 always-on clock driver Content-Language: en-US From: Hal Feng To: Emil Renner Berthing CC: , , , Stephen Boyd , "Michael Turquette" , Philipp Zabel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Palmer Dabbelt" , Paul Walmsley , Albert Ou , Ben Dooks , "Daniel Lezcano" , Thomas Gleixner , Marc Zyngier , References: <20230221024645.127922-1-hal.feng@starfivetech.com> <20230221024645.127922-13-hal.feng@starfivetech.com> <8c30220a-abef-7518-cb44-abcea91408e2@starfivetech.com> In-Reply-To: <8c30220a-abef-7518-cb44-abcea91408e2@starfivetech.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.96.115] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX172.cuchost.com (172.16.6.92) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 28 Feb 2023 10:42:35 +0800, Hal Feng wrote: > On Sun, 26 Feb 2023 18:34:52 +0100, Emil Renner Berthing wrote: >> On Tue, 21 Feb 2023 at 03:47, Hal Feng wrote: >>> From: Emil Renner Berthing >>> >>> Add driver for the StarFive JH7110 always-on clock controller >>> and register an auxiliary device for always-on reset controller >>> which is named as "reset-aon". >>> >>> Reported-by: kernel test robot >>> Signed-off-by: Emil Renner Berthing >>> Co-developed-by: Hal Feng >>> Signed-off-by: Hal Feng >>> --- >>> drivers/clk/starfive/Kconfig | 11 ++ >>> drivers/clk/starfive/Makefile | 1 + >>> .../clk/starfive/clk-starfive-jh7110-aon.c | 156 ++++++++++++++++++ >>> 3 files changed, 168 insertions(+) >>> create mode 100644 drivers/clk/starfive/clk-starfive-jh7110-aon.c >>> >>> diff --git a/drivers/clk/starfive/Kconfig b/drivers/clk/starfive/Kconfig >>> index 4640d0665d1c..2aa664f2cdee 100644 >>> --- a/drivers/clk/starfive/Kconfig >>> +++ b/drivers/clk/starfive/Kconfig >>> @@ -31,3 +31,14 @@ config CLK_STARFIVE_JH7110_SYS >>> help >>> Say yes here to support the system clock controller on the >>> StarFive JH7110 SoC. >>> + >>> +config CLK_STARFIVE_JH7110_AON >>> + tristate "StarFive JH7110 always-on clock support" >>> + depends on CLK_STARFIVE_JH7110_SYS >>> + select AUXILIARY_BUS >>> + select CLK_STARFIVE_JH71X0 >>> + select RESET_STARFIVE_JH7110 >>> + default CLK_STARFIVE_JH7110_SYS >> >> As far as I can tell the JH7110 boots fine without this driver and it >> already depends on the _SYS driver above, so please do >> >> default m if SOC_STARFIVE > > OK. Will fix it. Hi, Emil, The AON clock driver provides clocks for gmac0 which is used frequently. So I think it would be more convenient if we set "default y" here. Best regards, Hal