From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A50FFA373D for ; Fri, 28 Oct 2022 02:01:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234467AbiJ1CBL (ORCPT ); Thu, 27 Oct 2022 22:01:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234492AbiJ1CBK (ORCPT ); Thu, 27 Oct 2022 22:01:10 -0400 Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FA15537FA for ; Thu, 27 Oct 2022 19:01:09 -0700 (PDT) Received: by mail-qk1-x734.google.com with SMTP id b25so2623280qkk.7 for ; Thu, 27 Oct 2022 19:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VcEbkQyKWb0L/Kg+ZX5HS6lAAi/DowSIXYc8QAB2Kvg=; b=ewKFgj2VXv+7hOe1fSACo9aaYnFrC2eObv3KKRwT6XZ2Y8AxykC0UNMzi9vkpu9asf PeFG2R+MOYlyOHZ9so4lnwzQydIOI6jDJpLHlnXtGB1aUrnWoyrSl/Z5ISJjA4JsJ3/W VqFv7fAXe1zS7aQudC4D3J/ScT/8shcfjDZ6Y9RKQmz6Jl7u6eXiTujTuUzm0b4hLPL+ BB1dVtEU2LVYc70hHo4KZgzmMCgvyX0qIuTbhHcZVRoDbfnxbd8htJ6HoqxBIRMVUTL1 YSv2LSD8Pd8P90+54refqhPmqqpPjKR/2EYMWhjMXI6HitC6/GWmMrr3m2oxYqUBX4bW v1yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VcEbkQyKWb0L/Kg+ZX5HS6lAAi/DowSIXYc8QAB2Kvg=; b=lQpZ11SN9UtytJypD7m2jV5VHQuId86w2OsvscG/cqLhv+7+9Fz75/a/zimWgAdsu0 sv+QJLGSpkrMJ4noSFR4p6oIEDlFm/HvP+1W6yV+Mn91jrKVOR6MKDqB4f1bICRNTXCR rZuJ3sTLzBDZa6xf6IwSJJhJLBGATFpGW8EBUPDXOQvnJiCJ2l0Yr3eOM1kwJt16jy7+ Q/mWzNNDeX38R0Mp+WrmL81MFC3cPuwBJ5aqOituTsRPKv5cLeJnCKUa8ECKdOVbpdP9 c7VTwOXgHhUSA9rVo1rJ4gyFxtCbUKzgk5fyRB/R1OboQzNOul45oPcRLnGjpR3EwSOI S+sA== X-Gm-Message-State: ACrzQf1UdjQcNN7KGiDkh7ay2oTw0Y9qVmoIM9kWNj0fSvmwaD0zNbZR bkYLhDtZBJVK7kcnx8K3eML0dQ== X-Google-Smtp-Source: AMsMyM4d/n9swMkcWtvrJM2VCoFzwdy2vtmRKr+nsDpZ0zGmNvHHxuJUhYkQKjPr828IJ5kn0OOVMQ== X-Received: by 2002:a05:620a:254e:b0:6c9:cc85:c41a with SMTP id s14-20020a05620a254e00b006c9cc85c41amr37259351qko.260.1666922468461; Thu, 27 Oct 2022 19:01:08 -0700 (PDT) Received: from [192.168.1.11] ([64.57.193.93]) by smtp.gmail.com with ESMTPSA id r22-20020ac84256000000b0039467aadeb8sm1449703qtm.13.2022.10.27.19.01.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Oct 2022 19:01:07 -0700 (PDT) Message-ID: <49f504a1-e7c3-ade7-b4b4-e7571125b992@linaro.org> Date: Thu, 27 Oct 2022 22:01:05 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [EXT] Re: [PATCH v8 1/2] dt-bindings: fsl-imx-sdma: Convert imx sdma to DT schema Content-Language: en-US To: Joy Zou , "vkoul@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" Cc: "S.J. Wang" , "martink@posteo.de" , "dev@lynxeye.de" , "alexander.stein@ew.tq-group.com" , Peng Fan , "david@ixit.cz" , "aford173@gmail.com" , Hongxing Zhu , dl-linux-imx , "dmaengine@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" References: <20221025083609.2129260-1-joy.zou@nxp.com> <20221025083609.2129260-2-joy.zou@nxp.com> <133f27f4-d92c-ef8d-4fc9-32387518e4c0@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/10/2022 23:01, Joy Zou wrote: > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: 2022年10月26日 22:59 >> To: Joy Zou ; vkoul@kernel.org; robh+dt@kernel.org; >> krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org; >> s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com >> Cc: S.J. Wang ; martink@posteo.de; >> dev@lynxeye.de; alexander.stein@ew.tq-group.com; Peng Fan >> ; david@ixit.cz; aford173@gmail.com; Hongxing Zhu >> ; dl-linux-imx ; >> dmaengine@vger.kernel.org; devicetree@vger.kernel.org; >> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org >> Subject: [EXT] Re: [PATCH v8 1/2] dt-bindings: fsl-imx-sdma: Convert imx sdma >> to DT schema >> >> Caution: EXT Email >> >> On 25/10/2022 04:36, Joy Zou wrote: >>> Convert the i.MX SDMA binding to DT schema format using json-schema. >>> >>> The compatibles fsl,imx31-to1-sdma, fsl,imx31-to2-sdma, >>> fsl,imx35-to1-sdma and fsl,imx35-to2-sdma are not used. So need to >>> delete it. The compatibles fsl,imx50-sdma, fsl,imx6sll-sdma and >>> fsl,imx6sl-sdma are added. The original binding don't list all compatible used. >>> >>> In addition, add new peripheral types HDMI Audio. >>> >>> Signed-off-by: Joy Zou >>> --- >>> Changes in v8: >>> add the dma-controller quotes. >> >> Why adding quotes? > I refer to your comments in patch v7/1. The comment as follow: > +maintainers: > + - Joy Zou > + > You need to reference dma-controller.yaml schema. Yes, you need to reference dma-controller.yaml. Nothing about quotes. Reference is "$ref: .....yaml" > +properties: > + compatible: > + one of: > I misunderstand that add the dma-controller.yaml quotes. There was nothing about quotes - ". > So I am a little confused. Now, I see. > should I add dma-common.yaml quotes but not the dma-controller? Just drop " https://en.wikipedia.org/wiki/Quotation_mark Best regards, Krzysztof