From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
To: "Hans J. Koch" <hjk-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Cc: devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
Greg KH <gregkh-l3A5Bk7waGM@public.gmane.org>,
Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH 2/2] uio: add an of_genirq driver
Date: Sun, 14 Jun 2009 21:36:53 +0200 [thread overview]
Message-ID: <4A355155.4020500@grandegger.com> (raw)
In-Reply-To: <20090614192359.GG3639@local>
Hans J. Koch wrote:
> On Sun, Jun 14, 2009 at 09:05:33PM +0200, Wolfram Sang wrote:
>>> Anyway, 0 is a valid IRQ number, so it cannot be used as "no irq".
>> May I point you to this thread?
>>
>> http://lkml.org/lkml/2005/11/21/221
>
> Linus is just plain wrong in this 4 year old mail.
See also this related thread.
http://groups.google.com/group/rtc-linux/browse_thread/thread/9816648d5a8a1c9e/9968968188b5ab5a?lnk=gst&q=rx8025#9968968188b5ab5a
>
>> (The issue comes up once in a while as some archs still use NO_IRQ, some with
>> 0 some with -1)
>>
>>>> if (uioinfo->irq == NO_IRQ)
>>>> uioinfo->irq = UIO_IRQ_NONE;
>>> Sorry for my ignorance, but what is NO_IRQ? If I do
It's 0 on PowerPC but ARM seems still to use -1.
http://lxr.linux.no/linux+v2.6.30/arch/powerpc/include/asm/irq.h#L29
For x86 it's not defined at all. But as this code is for the PowerPC,
where using NO_IRQ seems still to be OK.
Wolfgang.
next prev parent reply other threads:[~2009-06-14 19:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 0:04 [PATCH 0/2] add OF wrapper for uio-pdrv-genirq Wolfram Sang
[not found] ` <1244765062-14144-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-06-12 0:04 ` [PATCH 1/2] uio/pdrv_genirq: Refactor probe routine to expose a generic part Wolfram Sang
2009-06-14 12:15 ` Hans J. Koch
2009-06-12 0:04 ` [PATCH 2/2] uio: add an of_genirq driver Wolfram Sang
2009-06-14 12:21 ` Hans J. Koch
2009-06-14 17:14 ` Wolfram Sang
[not found] ` <20090614171406.GA1010-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-06-14 18:33 ` Hans J. Koch
2009-06-14 19:05 ` Wolfram Sang
[not found] ` <20090614190533.GA7387-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-06-14 19:23 ` Hans J. Koch
2009-06-14 19:36 ` Wolfgang Grandegger [this message]
[not found] ` <4A355155.4020500-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2009-06-14 20:34 ` Hans J. Koch
2009-06-14 22:00 ` Wolfram Sang
[not found] ` <20090614220022.GB24323-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-06-14 23:01 ` Hans J. Koch
2009-06-14 23:46 ` Wolfram Sang
[not found] ` <20090614234643.GA17791-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-06-14 23:50 ` Hans J. Koch
2009-06-14 19:27 ` Greg KH
[not found] ` <20090614192707.GA11003-l3A5Bk7waGM@public.gmane.org>
2009-06-14 21:46 ` Wolfram Sang
2009-06-14 23:12 ` Alan Cox
[not found] ` <20090615001207.1829e7b5-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
2009-06-14 23:45 ` Hans J. Koch
2009-06-15 8:44 ` Alan Cox
2009-06-15 9:45 ` Benjamin Herrenschmidt
[not found] ` <1244765062-14144-3-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-06-14 14:40 ` Grant Likely
[not found] ` <fa686aa40906140740m43e9dd8am4d242310f681c95c-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-06-16 9:04 ` Wolfram Sang
2009-06-16 12:46 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A355155.4020500@grandegger.com \
--to=wg-5yr1bzd7o62+xt7jha+gda@public.gmane.org \
--cc=devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=gregkh-l3A5Bk7waGM@public.gmane.org \
--cc=hjk-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox