From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
To: Luotao Fu <l.fu-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
socketcan-users-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org
Subject: Re: [PATCH] mscan: add non-polling rx
Date: Fri, 30 Oct 2009 18:36:15 +0100 [thread overview]
Message-ID: <4AEB240F.1080408@grandegger.com> (raw)
In-Reply-To: <4AEB2328.6090009-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
Wolfgang Grandegger wrote:
> Luotao Fu wrote:
>> This one adds an option to turn of napi and process rx directly in mscan isr. As
>> for mpc52xx this feature can be turned on by setting a rx-irq property int the
>> device tree, e.g:
>> can@980 {
>> compatible = "fsl,mpc5200b-mscan","fsl,mpc5200-mscan";
>> interrupts = <2 18 0>;
>> rx-irq;
>> reg = <0x980 0x80>;
>> };
>> Default is the polling rx.
>>
>> Signed-off-by: Luotao Fu <l.fu-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
>
> This has little chance to be accepted as the device tree is about
> hardware. It should not be used to tell the driver what to do (software
> settings). I have CCed the devicetree-discuss ML for clarification.
Forgot the CC to devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Wolfgang.
next parent reply other threads:[~2009-10-30 17:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1256902073-22328-1-git-send-email-l.fu@pengutronix.de>
[not found] ` <4AEB2328.6090009@grandegger.com>
[not found] ` <4AEB2328.6090009-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2009-10-30 17:36 ` Wolfgang Grandegger [this message]
[not found] ` <4AEB240F.1080408-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2009-10-30 17:48 ` [Socketcan-users] [PATCH] mscan: add non-polling rx Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AEB240F.1080408@grandegger.com \
--to=wg-5yr1bzd7o62+xt7jha+gda@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=l.fu-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=socketcan-users-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox