From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nathan Fontenot Subject: Re: [RFC PATCH 2/5] Merge dynamic OF code to of_dynamic.c Date: Thu, 05 Nov 2009 10:59:22 -0600 Message-ID: <4AF3046A.4050508@austin.ibm.com> References: <4AF1FB29.50905@austin.ibm.com> <4AF1FD46.9050101@austin.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org To: Grant Likely Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@lists.ozlabs.org, microblaze-uclinux@itee.uq.edu.au List-Id: devicetree@vger.kernel.org Grant Likely wrote: > Hi Nathan, > > Thanks for the patches. Comments below. > > On Wed, Nov 4, 2009 at 3:16 PM, Nathan Fontenot wrote: >> Creation of the OF dynamic device tree update code in drivers/of. This >> merges the common device tree updating routines to add/remove nodes and >> properties from powerpc and microblaze. All of the new code is conditional >> based on a new OF_DYNAMIC config option. > > Rather than one patch to create all the moved functions, and then > subsequent patches to remove the duplicates from each arch, I've been > using the pattern of one patch for each function or couple of > functions to both remove from the old files and add to the new home. > Would you be able to do the same for your patches here? The merging > is complicated enough without having to track changes to a function > between separate commits. Moving one function at a time will also > make bisecting more friendly. > Shouldn't be a problem. > Also, have you checked what impact these changes have on SPARC? > I took a look at sparc code, but will do again as I redo the patches to make there are no impacts. >> --- linux-next.orig/drivers/of/Makefile 2009-11-03 11:18:08.000000000 -0600 >> +++ linux-next/drivers/of/Makefile 2009-11-03 13:42:35.000000000 -0600 >> @@ -1,6 +1,7 @@ >> obj-y = base.o >> -obj-$(CONFIG_OF_DEVICE) += device.o platform.o >> -obj-$(CONFIG_OF_GPIO) += gpio.o >> -obj-$(CONFIG_OF_I2C) += of_i2c.o >> -obj-$(CONFIG_OF_SPI) += of_spi.o >> -obj-$(CONFIG_OF_MDIO) += of_mdio.o >> +obj-$(CONFIG_OF_DEVICE) += device.o platform.o >> +obj-$(CONFIG_OF_GPIO) += gpio.o >> +obj-$(CONFIG_OF_I2C) += of_i2c.o >> +obj-$(CONFIG_OF_SPI) += of_spi.o >> +obj-$(CONFIG_OF_MDIO) += of_mdio.o >> +obj-$(CONFIG_OF_DYNAMIC) += of_dynamic.o > > Unrelated whitespace churn makes it hard to see what actually changed. > ok. -Nathan Fontenot