From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH 2/2] powerpc/mpc5121: add initial support for PDM360NG board Date: Mon, 03 May 2010 11:34:27 -0500 Message-ID: <4BDEFB13.5060407@freescale.com> References: <1272659448-23302-1-git-send-email-agust@denx.de> <1272659448-23302-2-git-send-email-agust@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Grant Likely Cc: Detlev Zundel , Markus Fischer , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Michael Weiss , linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, Wolfgang Grandegger List-Id: devicetree@vger.kernel.org Grant Likely wrote: >> + // IPIC >> + // interrupts cell = >> + // sense values match linux IORESOURCE_IRQ_* defines: >> + // sense == 8: Level, low assertion >> + // sense == 2: Edge, high-to-low change >> + // >> + ipic: interrupt-controller@c00 { >> + compatible = "fsl,mpc5121-ipic", "fsl,ipic"; >> + interrupt-controller; >> + #address-cells = <0>; > > Don't need #address-cells here #address-cells is required by ePAPR for interrupt controllers if an interrupt-map is used. While there isn't one in this tree, it's best to just always include #address-cells in interrupt controller nodes. -Scott