devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Walter Goossens <waltergoossens-CmkmPbn3yAE@public.gmane.org>
To: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: microblaze console init
Date: Sat, 11 Dec 2010 22:50:33 +0100	[thread overview]
Message-ID: <4D03F229.9070403@home.nl> (raw)

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

Hi list,

while working on fdt support for the nios2 I was reading some code for 
other archs I also looked at the microblaze code and I believe I found 
some leftovers from a copy/paste action, attached is a small patch 
(untested) to fix a debug print and (more important) remove a useless 
call to early_init_dt_check_for_initrd.

I do still have one concern, do I understand correctly that there is no 
way to do address-translation (the "ranges" stuff) on a flattenend tree, 
using the of_get_flat_dt_* functions? This would mean that this code 
would fail to get the correct address for a uartlite connected to a bus 
that has address-translation.

Greetingz
Walter

[-- Attachment #2: microblaze_prom_copy_paste_fix.patch --]
[-- Type: text/plain, Size: 702 bytes --]

diff --git a/arch/microblaze/kernel/prom.c b/arch/microblaze/kernel/prom.c
index a105301..c881393 100644
--- a/arch/microblaze/kernel/prom.c
+++ b/arch/microblaze/kernel/prom.c
@@ -61,14 +61,12 @@ static int __init early_init_dt_scan_serial(unsigned long node,
 	char *p;
 	int *addr;
 
-	pr_debug("search \"chosen\", depth: %d, uname: %s\n", depth, uname);
+	pr_debug("search \"serial\", depth: %d, uname: %s\n", depth, uname);
 
 /* find all serial nodes */
 	if (strncmp(uname, "serial", 6) != 0)
 		return 0;
 
-	early_init_dt_check_for_initrd(node);
-
 /* find compatible node with uartlite */
 	p = of_get_flat_dt_prop(node, "compatible", &l);
 	if ((strncmp(p, "xlnx,xps-uartlite", 17) != 0) &&

[-- Attachment #3: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

             reply	other threads:[~2010-12-11 21:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-11 21:50 Walter Goossens [this message]
     [not found] ` <4D03F229.9070403-CmkmPbn3yAE@public.gmane.org>
2010-12-11 21:59   ` microblaze console init Grant Likely
     [not found]     ` <AANLkTinw3mqpmiUkzf9Drgg+f+b3hFBUoHLmtWSO75GY-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-11 22:15       ` Walter Goossens
     [not found]         ` <4D03F803.6060903-CmkmPbn3yAE@public.gmane.org>
2010-12-11 22:18           ` Grant Likely
2010-12-11 22:24             ` Walter Goossens
     [not found]               ` <4D03FA1B.9040804-CmkmPbn3yAE@public.gmane.org>
2010-12-13 18:59                 ` Scott Wood
     [not found]                   ` <20101213125947.12a6db54-N/eSCTBpGwP7j4BuCOFQISmX4OfbXNuMKnGXBo5VDl8@public.gmane.org>
2010-12-13 21:06                     ` Walter Goossens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D03F229.9070403@home.nl \
    --to=waltergoossens-cmkmpbn3yae@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).