From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Subject: Re: [PATCH 2/4 v4] video, sm501: add edid and commandline support Date: Tue, 25 Jan 2011 09:04:51 +0100 Message-ID: <4D3E8423.1090106@denx.de> References: <1291451028-22532-1-git-send-email-hs@denx.de> <1295863047-11131-1-git-send-email-hs@denx.de> <20110125075104.GJ11673@linux-sh.org> Reply-To: hs-ynQEQJNshbs@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20110125075104.GJ11673-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Paul Mundt Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, Samuel Ortiz , Vincent Sanders , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ben Dooks , Randy Dunlap , linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org Hello Paul, Paul Mundt wrote: > On Mon, Jan 24, 2011 at 10:57:27AM +0100, Heiko Schocher wrote: >> @@ -1884,7 +1935,6 @@ static int __devinit sm501fb_probe(struct platform_device *pdev) >> >> if (info->pdata == NULL) { >> dev_info(dev, "using default configuration data\n"); >> - info->pdata = &sm501fb_def_pdata; >> } >> >> /* probe for the presence of each panel */ > > I assume this is accidental? I don't see how you're compensating for this > in any of the other patches at least, as it's orthogonal from the default > mode settings. Seems so, rework this too, thanks! bye, heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany