From mboxrd@z Thu Jan 1 00:00:00 1970 From: Walter Goossens Subject: Re: [PATCH v2] altera_ps2: Add devicetree support Date: Thu, 03 Feb 2011 23:27:21 +0100 Message-ID: <4D4B2BC9.1030000@home.nl> References: <20110117220415.GB17963@angua.secretlab.ca> <1295848693-28472-1-git-send-email-thomas@wytron.com.tw> <20110202043121.GF29148@angua.secretlab.ca> <4D4944AA.5040900@wytron.com.tw> <20110202153959.GD20275@angua.secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110202153959.GD20275-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Grant Likely Cc: nios2-dev-1eJk0qcHJCcaeqlQEoCUNoJY59XmG8rH@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Dmitry Torokhov , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 2/2/11 4:39 PM, Grant Likely wrote: > On Wed, Feb 02, 2011 at 07:48:58PM +0800, Thomas Chou wrote: >> On 02/02/2011 12:31 PM, Grant Likely wrote: >>>> +static const struct of_device_id altera_ps2_match[] = { >>>> + { .compatible = "altr,ps2-1.0", }, >>> I thought I had seen 'altera' instead of an abbreviation being used in >>> a previous patch. I don't care much whether 'altr' or 'altera' is >>> used, but I'd like to know that there is consensus from the Altera >>> users so that all the drivers use the same prefix. >>> >> We had discussed on nios2-dev mailing list, and decided to use >> 'altr' as Walter suggested that it saves space. > Is altr the stock ticker symbol? The convention is to either use the > stock ticker in all uppercase (although the uppercase bit hasn't been > consistently applied), or to use the full name in lowercase. > > g. > > Risking my limbs here by breaking in this late in the discussion... (I wasn't able to reply earlier) but where does it state it needs to be uppercase? I found a bunch of microblaze code which seems to use the lowercase xlnx and freescale seems happy with fsl. Unless I'm missing something obvious here I guess ALTR would actually be the first to use uppercase. The only reference to uppercase I found in the ePAPR docs was chapter 1.6 that talks about uppercase hex-characters as an OUI. Not that I terribly mind either way, but I want to double-check before we go ahead and change all altera-related devicetree stuff to uppercase. Greetz Walter