Re: [PATCH 2/4] ARM: DT: Add a basic dts file for SMDKV310 machine

[Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

David, Thomas,

On 02/06/2011 06:04 PM, David Gibson wrote:
> On Sun, Feb 06, 2011 at 06:47:28PM +0530, Thomas Abraham wrote:
>> This patch adds a basic dts file for Samsung's SMDKV310 machine.
>>
>> Signed-off-by: Thomas Abraham<thomas.abraham-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> ---
>>   arch/arm/mach-s5pv310/mach-smdkv310.dts |   38 +++++++++++++++++++++++++++++++
>>   1 files changed, 38 insertions(+), 0 deletions(-)
>>   create mode 100755 arch/arm/mach-s5pv310/mach-smdkv310.dts
>>
>> diff --git a/arch/arm/mach-s5pv310/mach-smdkv310.dts b/arch/arm/mach-s5pv310/mach-smdkv310.dts
>> new file mode 100755
>> index 0000000..74d80bf
>> --- /dev/null
>> +++ b/arch/arm/mach-s5pv310/mach-smdkv310.dts
>> @@ -0,0 +1,38 @@
>> +/dts-v1/;
>> +
>> +/ {
>> +	model = "smdkv310";
>> +	compatible = "samsung,smdkv310";
>> +	#address-cells =<1>;
>> +	#size-cells =<1>;
>> +
>> +	memory {
>> +		device_type = "memory";
>> +		reg =<0x40000000 0x08000000>;
>> +	};
>
> Uh.. where are the cpus?
>

But for ARM, all the details of the cpu are probe-able. So what would we 
gain by putting cpu info in the DTS?

>> +	chosen {
>> +		bootargs = "root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M console=ttySAC1,115200 init=/linuxrc";
>> +	};
>> +
>> +	soc {
>> +		#address-cells =<1>;
>> +		#size-cells =<1>;
>> +		compatible = "simple-bus";
>
> It's generally a good idea to list the specific soc model before "simple-bus".
>
>> +		ranges =<0x00000000 0x00000000 0xFFFFFFFF>;

For no translation, you can do just:

ranges;

Rob