From: Paolo Bonzini <pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH] libfdt: include version number in soname
Date: Mon, 25 Apr 2011 20:09:20 +0200 [thread overview]
Message-ID: <4DB5B8D0.90802@redhat.com> (raw)
In-Reply-To: <20110425030733.GA6263@yookeroo>
On 04/25/2011 05:07 AM, David Gibson wrote:
> it sets the SONAME containing the whole of the dtc version, which
> means even minor version updates will cause a change of soname and
> will therefore be seen as incompatible changes.
Squashing this in should be enough:
diff --git a/Makefile b/Makefile
index 1db9f30..e29cd25 100644
--- a/Makefile
+++ b/Makefile
@@ -131,7 +131,7 @@ LIBFDT_objdir = libfdt
LIBFDT_srcdir = libfdt
LIBFDT_archive = $(LIBFDT_objdir)/libfdt.a
LIBFDT_lib = $(LIBFDT_objdir)/libfdt.$(SHAREDLIB_EXT)
-LIBFDT_lib_VERSIONED = $(subst .$(SHAREDLIB_EXT),-$(DTC_VERSION).$(SHAREDLIB_EXT),$(LIBFDT_lib))
+LIBFDT_lib_VERSIONED = $(subst .$(SHAREDLIB_EXT),.$(SHAREDLIB_EXT).$(VERSION),$(LIBFDT_lib))
LIBFDT_lib_SONAME = $(notdir $(LIBFDT_lib_VERSIONED))
LIBFDT_include = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_INCLUDES))
LIBFDT_version = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_VERSION))
Paolo
next prev parent reply other threads:[~2011-04-25 18:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 10:13 [PATCH] libfdt: include version number in soname Paolo Bonzini
[not found] ` <1303380829-16965-1-git-send-email-pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-04-25 3:07 ` David Gibson
2011-04-25 18:09 ` Paolo Bonzini [this message]
[not found] ` <4DB5B8D0.90802-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-04-26 10:45 ` David Gibson
2011-04-26 11:16 ` Paolo Bonzini
[not found] ` <4DB6A98B.6020107-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-04-26 15:19 ` David Gibson
2011-04-29 13:48 ` Jon Loeliger
[not found] ` <E1QFo3q-0001O9-IK-CYoMK+44s/E@public.gmane.org>
2011-04-29 14:06 ` Paolo Bonzini
[not found] ` <4DBAC5F0.8050409-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-04-29 14:48 ` Jon Loeliger
[not found] ` <E1QFoza-0001mA-2y-CYoMK+44s/E@public.gmane.org>
2011-04-29 14:50 ` Paolo Bonzini
2011-05-11 14:29 ` Domenico Andreoli
[not found] ` <20110511142953.GA8845-iIV0ii4H0r6tG0bUXCXiUA@public.gmane.org>
2011-05-11 14:36 ` Jon Loeliger
2011-05-11 15:06 ` David Gibson
2011-05-11 15:13 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB5B8D0.90802@redhat.com \
--to=pbonzini-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).