* [PATCH] libfdt: include version number in soname
@ 2011-04-21 10:13 Paolo Bonzini
[not found] ` <1303380829-16965-1-git-send-email-pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 14+ messages in thread
From: Paolo Bonzini @ 2011-04-21 10:13 UTC (permalink / raw)
To: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
The libfdt shared library is only installed by its unversioned name.
Including it properly in a distribution requires installation of both
the versioned name (used in the binary-only package) and the unversioned
name (used in the development package). The latter is just a symbolic
link, so you need to change the soname in turn to include the version.
While at it, use Makefile variables to shorten some lines and avoid
cut-and-paste typos; and clean up remnants of when shared libraries were
not supported on Darwin.
Signed-off-by: Paolo Bonzini <pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
Makefile | 14 ++++++++------
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/Makefile b/Makefile
index a07648c..1db9f30 100644
--- a/Makefile
+++ b/Makefile
@@ -131,9 +131,10 @@ LIBFDT_objdir = libfdt
LIBFDT_srcdir = libfdt
LIBFDT_archive = $(LIBFDT_objdir)/libfdt.a
LIBFDT_lib = $(LIBFDT_objdir)/libfdt.$(SHAREDLIB_EXT)
+LIBFDT_lib_VERSIONED = $(subst .$(SHAREDLIB_EXT),-$(DTC_VERSION).$(SHAREDLIB_EXT),$(LIBFDT_lib))
+LIBFDT_lib_SONAME = $(notdir $(LIBFDT_lib_VERSIONED))
LIBFDT_include = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_INCLUDES))
LIBFDT_version = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_VERSION))
-
include $(LIBFDT_srcdir)/Makefile.libfdt
.PHONY: libfdt
@@ -145,7 +146,7 @@ $(LIBFDT_lib): $(addprefix $(LIBFDT_objdir)/,$(LIBFDT_OBJS))
libfdt_clean:
@$(VECHO) CLEAN "(libfdt)"
rm -f $(addprefix $(LIBFDT_objdir)/,$(STD_CLEANFILES))
- rm -f $(LIBFDT_objdir)/*.so
+ rm -f $(LIBFDT_objdir)/*.$(SHAREDLIB_EXT)
ifneq ($(DEPTARGETS),)
-include $(LIBFDT_OBJS:%.o=$(LIBFDT_objdir)/%.d)
@@ -161,7 +162,8 @@ install: all $(SCRIPTS)
$(INSTALL) -d $(DESTDIR)$(BINDIR)
$(INSTALL) $(BIN) $(SCRIPTS) $(DESTDIR)$(BINDIR)
$(INSTALL) -d $(DESTDIR)$(LIBDIR)
- $(INSTALL) $(LIBFDT_lib) $(DESTDIR)$(LIBDIR)
+ $(INSTALL) $(LIBFDT_lib_VERSIONED) $(DESTDIR)$(LIBDIR)
+ ln -sf $(notdir $(LIBFDT_lib_VERSIONED)) $(DESTDIR)$(LIBDIR)/$(notdir $(LIBFDT_lib))
$(INSTALL) -m 644 $(LIBFDT_archive) $(DESTDIR)$(LIBDIR)
$(INSTALL) -d $(DESTDIR)$(INCLUDEDIR)
$(INSTALL) -m 644 $(LIBFDT_include) $(DESTDIR)$(INCLUDEDIR)
@@ -188,7 +190,7 @@ include tests/Makefile.tests
#
# Clean rules
#
-STD_CLEANFILES = *~ *.o *.so *.d *.a *.i *.s core a.out vgcore.* \
+STD_CLEANFILES = *~ *.o *.$(SHAREDLIB_EXT) *.d *.a *.i *.s core a.out vgcore.* \
*.tab.[ch] *.lex.c *.output
clean: libfdt_clean tests_clean
@@ -234,8 +236,8 @@ clean: libfdt_clean tests_clean
$(LIBFDT_lib):
@$(VECHO) LD $@
- $(CC) $(LDFLAGS) -fPIC $(SHAREDLIB_LINK_OPTIONS)$(notdir $@) -o $(LIBFDT_objdir)/libfdt-$(DTC_VERSION).$(SHAREDLIB_EXT) $^
- ln -sf libfdt-$(DTC_VERSION).$(SHAREDLIB_EXT) $(LIBFDT_objdir)/libfdt.$(SHAREDLIB_EXT)
+ $(CC) $(LDFLAGS) -fPIC $(SHAREDLIB_LINK_OPTIONS)$(LIBFDT_lib_SONAME) -o $(LIBFDT_lib_VERSIONED) $^
+ ln -sf $(notdir $(LIBFDT_lib_VERSIONED)) $(LIBFDT_lib)
%.lex.c: %.l
@$(VECHO) LEX $@
--
1.7.4.4
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] libfdt: include version number in soname
[not found] ` <1303380829-16965-1-git-send-email-pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
@ 2011-04-25 3:07 ` David Gibson
2011-04-25 18:09 ` Paolo Bonzini
0 siblings, 1 reply; 14+ messages in thread
From: David Gibson @ 2011-04-25 3:07 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
On Thu, Apr 21, 2011 at 12:13:49PM +0200, Paolo Bonzini wrote:
> The libfdt shared library is only installed by its unversioned name.
> Including it properly in a distribution requires installation of both
> the versioned name (used in the binary-only package) and the unversioned
> name (used in the development package). The latter is just a symbolic
> link, so you need to change the soname in turn to include the version.
>
> While at it, use Makefile variables to shorten some lines and avoid
> cut-and-paste typos; and clean up remnants of when shared libraries were
> not supported on Darwin.
So, as it happens, I was attempting to package libfdt just a few days
ago and also hit problems because the shared library was not properly
versioned. That was more due to the lack of SONAME entry in the ELF
itself, rather than the missing installed filename.
However this patch isn't quite right - it sets the SONAME containing
the whole of the dtc version, which means even minor version updates
will cause a change of soname and will therefore be seen as
incompatible changes.
I'll revise and send out a version with both sign-offs in a moment.
Jon, it would be really good to squeeze this one into the mooted
upcoming official release - it would then be a good base for the
distros to build proper libfdt packages from.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] libfdt: include version number in soname
2011-04-25 3:07 ` David Gibson
@ 2011-04-25 18:09 ` Paolo Bonzini
[not found] ` <4DB5B8D0.90802-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 14+ messages in thread
From: Paolo Bonzini @ 2011-04-25 18:09 UTC (permalink / raw)
To: David Gibson; +Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
On 04/25/2011 05:07 AM, David Gibson wrote:
> it sets the SONAME containing the whole of the dtc version, which
> means even minor version updates will cause a change of soname and
> will therefore be seen as incompatible changes.
Squashing this in should be enough:
diff --git a/Makefile b/Makefile
index 1db9f30..e29cd25 100644
--- a/Makefile
+++ b/Makefile
@@ -131,7 +131,7 @@ LIBFDT_objdir = libfdt
LIBFDT_srcdir = libfdt
LIBFDT_archive = $(LIBFDT_objdir)/libfdt.a
LIBFDT_lib = $(LIBFDT_objdir)/libfdt.$(SHAREDLIB_EXT)
-LIBFDT_lib_VERSIONED = $(subst .$(SHAREDLIB_EXT),-$(DTC_VERSION).$(SHAREDLIB_EXT),$(LIBFDT_lib))
+LIBFDT_lib_VERSIONED = $(subst .$(SHAREDLIB_EXT),.$(SHAREDLIB_EXT).$(VERSION),$(LIBFDT_lib))
LIBFDT_lib_SONAME = $(notdir $(LIBFDT_lib_VERSIONED))
LIBFDT_include = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_INCLUDES))
LIBFDT_version = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_VERSION))
Paolo
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] libfdt: include version number in soname
[not found] ` <4DB5B8D0.90802-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
@ 2011-04-26 10:45 ` David Gibson
2011-04-26 11:16 ` Paolo Bonzini
0 siblings, 1 reply; 14+ messages in thread
From: David Gibson @ 2011-04-26 10:45 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
On Mon, Apr 25, 2011 at 08:09:20PM +0200, Paolo Bonzini wrote:
> On 04/25/2011 05:07 AM, David Gibson wrote:
> > it sets the SONAME containing the whole of the dtc version, which
> > means even minor version updates will cause a change of soname and
> > will therefore be seen as incompatible changes.
>
> Squashing this in should be enough:
Minimally, yes. But I think we can do a bit better. In particular
I'd prefer not to tie the soname directly to the dtc version at all.
Updates to dtc are only vaguely in sync with libfdt updates, and since
we are symbol versioning in libfdt, even pretty significant changes in
libfdt won't break backwards compatibility if we do things right.
So here's my patch version instead. Jon, please apply.
libfdt: include version number in soname
From: Paolo Bonzini <pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
The libfdt shared library is only installed by its unversioned name.
Including it properly in a distribution requires installation of both
the versioned name (used in the binary-only package) and the unversioned
name (used in the development package). The latter is just a symbolic
link, so you need to change the soname in turn to include the version.
While at it, use Makefile variables to shorten some lines and avoid
cut-and-paste typos; and clean up remnants of when shared libraries were
not supported on Darwin.
Signed-off-by: Paolo Bonzini <pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Signed-off-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
---
Index: dtc/Makefile
===================================================================
--- dtc.orig/Makefile 2011-04-11 13:47:41.196663143 +1000
+++ dtc/Makefile 2011-04-26 20:39:18.679649937 +1000
@@ -130,7 +130,7 @@ endif
LIBFDT_objdir = libfdt
LIBFDT_srcdir = libfdt
LIBFDT_archive = $(LIBFDT_objdir)/libfdt.a
-LIBFDT_lib = $(LIBFDT_objdir)/libfdt.$(SHAREDLIB_EXT)
+LIBFDT_lib = $(LIBFDT_objdir)/libfdt-$(DTC_VERSION).$(SHAREDLIB_EXT)
LIBFDT_include = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_INCLUDES))
LIBFDT_version = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_VERSION))
@@ -162,6 +162,8 @@ install: all $(SCRIPTS)
$(INSTALL) $(BIN) $(SCRIPTS) $(DESTDIR)$(BINDIR)
$(INSTALL) -d $(DESTDIR)$(LIBDIR)
$(INSTALL) $(LIBFDT_lib) $(DESTDIR)$(LIBDIR)
+ ln -sf $(notdir $(LIBFDT_lib)) $(DESTDIR)$(LIBDIR)/$(LIBFDT_soname)
+ ln -sf $(LIBFDT_soname) $(DESTDIR)$(LIBDIR)/libfdt.$(SHAREDLIB_EXT)
$(INSTALL) -m 644 $(LIBFDT_archive) $(DESTDIR)$(LIBDIR)
$(INSTALL) -d $(DESTDIR)$(INCLUDEDIR)
$(INSTALL) -m 644 $(LIBFDT_include) $(DESTDIR)$(INCLUDEDIR)
@@ -188,7 +190,7 @@ include tests/Makefile.tests
#
# Clean rules
#
-STD_CLEANFILES = *~ *.o *.so *.d *.a *.i *.s core a.out vgcore.* \
+STD_CLEANFILES = *~ *.o *.$(SHAREDLIB_EXT) *.d *.a *.i *.s core a.out vgcore.* \
*.tab.[ch] *.lex.c *.output
clean: libfdt_clean tests_clean
@@ -234,8 +236,7 @@ clean: libfdt_clean tests_clean
$(LIBFDT_lib):
@$(VECHO) LD $@
- $(CC) $(LDFLAGS) -fPIC $(SHAREDLIB_LINK_OPTIONS)$(notdir $@) -o $(LIBFDT_objdir)/libfdt-$(DTC_VERSION).$(SHAREDLIB_EXT) $^
- ln -sf libfdt-$(DTC_VERSION).$(SHAREDLIB_EXT) $(LIBFDT_objdir)/libfdt.$(SHAREDLIB_EXT)
+ $(CC) $(LDFLAGS) -fPIC $(SHAREDLIB_LINK_OPTIONS)$(LIBFDT_SONAME) -o $(LIBFDT_lib) $^
%.lex.c: %.l
@$(VECHO) LEX $@
Index: dtc/libfdt/Makefile.libfdt
===================================================================
--- dtc.orig/libfdt/Makefile.libfdt 2011-04-25 13:08:15.102770001 +1000
+++ dtc/libfdt/Makefile.libfdt 2011-04-25 13:09:42.778770001 +1000
@@ -3,6 +3,7 @@
# This is not a complete Makefile of itself. Instead, it is designed to
# be easily embeddable into other systems of Makefiles.
#
+LIBFDT_soname = libfdt.$(SHAREDLIB_EXT).1
LIBFDT_INCLUDES = fdt.h libfdt.h
LIBFDT_VERSION = version.lds
LIBFDT_SRCS = fdt.c fdt_ro.c fdt_wip.c fdt_sw.c fdt_rw.c fdt_strerror.c
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] libfdt: include version number in soname
2011-04-26 10:45 ` David Gibson
@ 2011-04-26 11:16 ` Paolo Bonzini
[not found] ` <4DB6A98B.6020107-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 14+ messages in thread
From: Paolo Bonzini @ 2011-04-26 11:16 UTC (permalink / raw)
To: David Gibson; +Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
On 04/26/2011 12:45 PM, David Gibson wrote:
> Minimally, yes. But I think we can do a bit better. In particular
> I'd prefer not to tie the soname directly to the dtc version at all.
> Updates to dtc are only vaguely in sync with libfdt updates, and since
> we are symbol versioning in libfdt, even pretty significant changes in
> libfdt won't break backwards compatibility if we do things right.
>
> So here's my patch version instead. Jon, please apply.
>
> libfdt: include version number in soname
>
> From: Paolo Bonzini<pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>
> The libfdt shared library is only installed by its unversioned name.
> Including it properly in a distribution requires installation of both
> the versioned name (used in the binary-only package) and the unversioned
> name (used in the development package). The latter is just a symbolic
> link, so you need to change the soname in turn to include the version.
>
> While at it, use Makefile variables to shorten some lines and avoid
> cut-and-paste typos; and clean up remnants of when shared libraries were
> not supported on Darwin.
>
> Signed-off-by: Paolo Bonzini<pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: David Gibson<david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
This:
+ $(CC) $(LDFLAGS) -fPIC $(SHAREDLIB_LINK_OPTIONS)$(LIBFDT_SONAME) -o $(LIBFDT_lib) $^
should be $(LIBFDT_soname).
ACK with that change.
Paolo
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] libfdt: include version number in soname
[not found] ` <4DB6A98B.6020107-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
@ 2011-04-26 15:19 ` David Gibson
2011-04-29 13:48 ` Jon Loeliger
0 siblings, 1 reply; 14+ messages in thread
From: David Gibson @ 2011-04-26 15:19 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
On Tue, Apr 26, 2011 at 01:16:27PM +0200, Paolo Bonzini wrote:
> On 04/26/2011 12:45 PM, David Gibson wrote:
> > Minimally, yes. But I think we can do a bit better. In particular
> > I'd prefer not to tie the soname directly to the dtc version at all.
> > Updates to dtc are only vaguely in sync with libfdt updates, and since
> > we are symbol versioning in libfdt, even pretty significant changes in
> > libfdt won't break backwards compatibility if we do things right.
> >
> > So here's my patch version instead. Jon, please apply.
> >
> > libfdt: include version number in soname
> >
> > From: Paolo Bonzini<pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> >
> > The libfdt shared library is only installed by its unversioned name.
> > Including it properly in a distribution requires installation of both
> > the versioned name (used in the binary-only package) and the unversioned
> > name (used in the development package). The latter is just a symbolic
> > link, so you need to change the soname in turn to include the version.
> >
> > While at it, use Makefile variables to shorten some lines and avoid
> > cut-and-paste typos; and clean up remnants of when shared libraries were
> > not supported on Darwin.
> >
> > Signed-off-by: Paolo Bonzini<pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > Signed-off-by: David Gibson<david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
>
> This:
>
> + $(CC) $(LDFLAGS) -fPIC $(SHAREDLIB_LINK_OPTIONS)$(LIBFDT_SONAME) -o $(LIBFDT_lib) $^
>
> should be $(LIBFDT_soname).
Ugh, yes, instead of $(LIBFDT_SONAME) to be clear. I did check the
soname on my build, I must have made an accidental press of M-u after
I did so, sorry.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] libfdt: include version number in soname
2011-04-26 15:19 ` David Gibson
@ 2011-04-29 13:48 ` Jon Loeliger
[not found] ` <E1QFo3q-0001O9-IK-CYoMK+44s/E@public.gmane.org>
0 siblings, 1 reply; 14+ messages in thread
From: Jon Loeliger @ 2011-04-29 13:48 UTC (permalink / raw)
To: David Gibson; +Cc: Paolo Bonzini, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
> On Tue, Apr 26, 2011 at 01:16:27PM +0200, Paolo Bonzini wrote:
> > On 04/26/2011 12:45 PM, David Gibson wrote:
> > >
> > > libfdt: include version number in soname
> > >
> > > From: Paolo Bonzini<pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > >
> > > The libfdt shared library is only installed by its unversioned name.
> > > Including it properly in a distribution requires installation of both
> > > the versioned name (used in the binary-only package) and the unversioned
> > > name (used in the development package). The latter is just a symbolic
> > > link, so you need to change the soname in turn to include the version.
> > >
> > > While at it, use Makefile variables to shorten some lines and avoid
> > > cut-and-paste typos; and clean up remnants of when shared libraries were
> > > not supported on Darwin.
> > >
> > > Signed-off-by: Paolo Bonzini<pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > > Signed-off-by: David Gibson<david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
> >
> > This:
> >
> > + $(CC) $(LDFLAGS) -fPIC $(SHAREDLIB_LINK_OPTIONS)$(LIBFDT_SONAME) -o $(LIBFDT_lib) $^
> >
> > should be $(LIBFDT_soname).
>
> Ugh, yes, instead of $(LIBFDT_SONAME) to be clear. I did check the
> soname on my build, I must have made an accidental press of M-u after
> I did so, sorry.
Applied with last-minute mod and pushed out.
Consider this the candidate for a 1.3.0 release!
Thanks!
jdl
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] libfdt: include version number in soname
[not found] ` <E1QFo3q-0001O9-IK-CYoMK+44s/E@public.gmane.org>
@ 2011-04-29 14:06 ` Paolo Bonzini
[not found] ` <4DBAC5F0.8050409-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-05-11 14:29 ` Domenico Andreoli
1 sibling, 1 reply; 14+ messages in thread
From: Paolo Bonzini @ 2011-04-29 14:06 UTC (permalink / raw)
To: Jon Loeliger; +Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
On 04/29/2011 03:48 PM, Jon Loeliger wrote:
> Applied with last-minute mod and pushed out.
>
> Consider this the candidate for a 1.3.0 release!
Don't forget to bump the version number. ;)
Paolo
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] libfdt: include version number in soname
[not found] ` <4DBAC5F0.8050409-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
@ 2011-04-29 14:48 ` Jon Loeliger
[not found] ` <E1QFoza-0001mA-2y-CYoMK+44s/E@public.gmane.org>
0 siblings, 1 reply; 14+ messages in thread
From: Jon Loeliger @ 2011-04-29 14:48 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
> On 04/29/2011 03:48 PM, Jon Loeliger wrote:
> > Applied with last-minute mod and pushed out.
> >
> > Consider this the candidate for a 1.3.0 release!
>
> Don't forget to bump the version number. ;)
Yeah. You want that now for testing? Or just with the release?
jdl
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] libfdt: include version number in soname
[not found] ` <E1QFoza-0001mA-2y-CYoMK+44s/E@public.gmane.org>
@ 2011-04-29 14:50 ` Paolo Bonzini
0 siblings, 0 replies; 14+ messages in thread
From: Paolo Bonzini @ 2011-04-29 14:50 UTC (permalink / raw)
To: Jon Loeliger; +Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
On 04/29/2011 04:48 PM, Jon Loeliger wrote:
> > > Consider this the candidate for a 1.3.0 release!
> >
> > Don't forget to bump the version number.;)
>
> Yeah. You want that now for testing? Or just with the release?
It should be done for a proper rc of course; anyway I did that myself
for testing and the git HEAD is fine as far as the shared library
support is concerned.
Paolo
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] libfdt: include version number in soname
[not found] ` <E1QFo3q-0001O9-IK-CYoMK+44s/E@public.gmane.org>
2011-04-29 14:06 ` Paolo Bonzini
@ 2011-05-11 14:29 ` Domenico Andreoli
[not found] ` <20110511142953.GA8845-iIV0ii4H0r6tG0bUXCXiUA@public.gmane.org>
1 sibling, 1 reply; 14+ messages in thread
From: Domenico Andreoli @ 2011-05-11 14:29 UTC (permalink / raw)
To: Jon Loeliger; +Cc: Paolo Bonzini, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
Hi Jon,
On Fri, Apr 29, 2011 at 08:48:46AM -0500, Jon Loeliger wrote:
> > On Tue, Apr 26, 2011 at 01:16:27PM +0200, Paolo Bonzini wrote:
> > > On 04/26/2011 12:45 PM, David Gibson wrote:
> > > >
> > > > The libfdt shared library is only installed by its unversioned name.
> > > > Including it properly in a distribution requires installation of both
> > > > the versioned name (used in the binary-only package) and the unversioned
> > > > name (used in the development package). The latter is just a symbolic
> > > > link, so you need to change the soname in turn to include the version.
>
> Applied with last-minute mod and pushed out.
>
> Consider this the candidate for a 1.3.0 release!
I'm considering to package dtc for Debian, do you plan to release
tarballs or is git the only way you release dtc? I'm seeing the v1.3.0
tag, is it already the final release?
What libfdt is used for? Why dtc does not depend on it? Is there any
other user-space tool that may use libfdt? I need to understand if it's
appropriate to have the following packages: dtc, libfdt and libfdt-dev.
Are you available to host debian specific subdir containing all the
packaging details (few files)? Has dtc an homepage or only the gitweb?
This is not an intent statement yet, I'm an almost retired debian
developer but since the packaging effort is rather low I could think
to take it anyway. If anybody else is available I will happily leave
it to him.
thanks,
Domenico
-----[ Domenico Andreoli, aka cavok
--[ http://cavokz.wordpress.com/gpgkey/
---[ 3A0F 2F80 F79C 678A 8936 4FEE 0677 9033 A20E BC50
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] libfdt: include version number in soname
[not found] ` <20110511142953.GA8845-iIV0ii4H0r6tG0bUXCXiUA@public.gmane.org>
@ 2011-05-11 14:36 ` Jon Loeliger
2011-05-11 15:06 ` David Gibson
2011-05-11 15:13 ` Paolo Bonzini
2 siblings, 0 replies; 14+ messages in thread
From: Jon Loeliger @ 2011-05-11 14:36 UTC (permalink / raw)
To: Domenico Andreoli
Cc: Paolo Bonzini, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
> Hi Jon,
>
> > Consider this the candidate for a 1.3.0 release!
>
> I'm considering to package dtc for Debian, do you plan to release
> tarballs or is git the only way you release dtc? I'm seeing the v1.3.0
> tag, is it already the final release?
No formal, tagged 1.3.0-rc was released.
Something like:
$ wget http://git.jdl.com/software/dtc-v1.3.0.tgz
should work.
HTH,
jdl
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] libfdt: include version number in soname
[not found] ` <20110511142953.GA8845-iIV0ii4H0r6tG0bUXCXiUA@public.gmane.org>
2011-05-11 14:36 ` Jon Loeliger
@ 2011-05-11 15:06 ` David Gibson
2011-05-11 15:13 ` Paolo Bonzini
2 siblings, 0 replies; 14+ messages in thread
From: David Gibson @ 2011-05-11 15:06 UTC (permalink / raw)
To: Jon Loeliger, Paolo Bonzini,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
On Wed, May 11, 2011 at 04:29:53PM +0200, Domenico Andreoli wrote:
> Hi Jon,
>
> On Fri, Apr 29, 2011 at 08:48:46AM -0500, Jon Loeliger wrote:
> > > On Tue, Apr 26, 2011 at 01:16:27PM +0200, Paolo Bonzini wrote:
> > > > On 04/26/2011 12:45 PM, David Gibson wrote:
> > > > >
> > > > > The libfdt shared library is only installed by its unversioned name.
> > > > > Including it properly in a distribution requires installation of both
> > > > > the versioned name (used in the binary-only package) and the unversioned
> > > > > name (used in the development package). The latter is just a symbolic
> > > > > link, so you need to change the soname in turn to include the version.
> >
> > Applied with last-minute mod and pushed out.
> >
> > Consider this the candidate for a 1.3.0 release!
>
> I'm considering to package dtc for Debian, do you plan to release
> tarballs or is git the only way you release dtc? I'm seeing the v1.3.0
> tag, is it already the final release?
dtc is already packaged in Debian, under the package name
'device-tree-compiler'. However the package is missing some stuff,
and doesn't include libfdt at all.
> What libfdt is used for?
libfdt is used for manipulating device trees at run time. It can be
used by bootloaders or kernels as well as userspace programs.
> Why dtc does not depend on it?
Partly history, partly because dtc does not do much runtime
manipulation of trees in flattened form, partly because having
separate implementations allows them to be tested against each other.
> Is there any
> other user-space tool that may use libfdt?
qemu can use libfdt in some configurations.
> I need to understand if it's
> appropriate to have the following packages: dtc, libfdt and
> libfdt-dev.
Yes, that would be appropriate, except it would be libfdt1, so that
debian's automatic shared library dependency stuff would work. This
is exactly what I did in a quick and dirty .deb I made for internal
use. lib32fdt1 and lib64fdt1 packages would also be useful.
> Are you available to host debian specific subdir containing all the
> packaging details (few files)? Has dtc an homepage or only the gitweb?
>
> This is not an intent statement yet, I'm an almost retired debian
> developer but since the packaging effort is rather low I could think
> to take it anyway. If anybody else is available I will happily leave
> it to him.
>
> thanks,
> Domenico
>
> -----[ Domenico Andreoli, aka cavok
> --[ http://cavokz.wordpress.com/gpgkey/
> ---[ 3A0F 2F80 F79C 678A 8936 4FEE 0677 9033 A20E BC50
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] libfdt: include version number in soname
[not found] ` <20110511142953.GA8845-iIV0ii4H0r6tG0bUXCXiUA@public.gmane.org>
2011-05-11 14:36 ` Jon Loeliger
2011-05-11 15:06 ` David Gibson
@ 2011-05-11 15:13 ` Paolo Bonzini
2 siblings, 0 replies; 14+ messages in thread
From: Paolo Bonzini @ 2011-05-11 15:13 UTC (permalink / raw)
To: Jon Loeliger, David Gibson,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
On 05/11/2011 04:29 PM, Domenico Andreoli wrote:
> What libfdt is used for?
QEMU uses it.
Paolo
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2011-05-11 15:13 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-21 10:13 [PATCH] libfdt: include version number in soname Paolo Bonzini
[not found] ` <1303380829-16965-1-git-send-email-pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-04-25 3:07 ` David Gibson
2011-04-25 18:09 ` Paolo Bonzini
[not found] ` <4DB5B8D0.90802-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-04-26 10:45 ` David Gibson
2011-04-26 11:16 ` Paolo Bonzini
[not found] ` <4DB6A98B.6020107-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-04-26 15:19 ` David Gibson
2011-04-29 13:48 ` Jon Loeliger
[not found] ` <E1QFo3q-0001O9-IK-CYoMK+44s/E@public.gmane.org>
2011-04-29 14:06 ` Paolo Bonzini
[not found] ` <4DBAC5F0.8050409-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-04-29 14:48 ` Jon Loeliger
[not found] ` <E1QFoza-0001mA-2y-CYoMK+44s/E@public.gmane.org>
2011-04-29 14:50 ` Paolo Bonzini
2011-05-11 14:29 ` Domenico Andreoli
[not found] ` <20110511142953.GA8845-iIV0ii4H0r6tG0bUXCXiUA@public.gmane.org>
2011-05-11 14:36 ` Jon Loeliger
2011-05-11 15:06 ` David Gibson
2011-05-11 15:13 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).