From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v4 2/4] dt: add EXPORT_SYMBOL to of_platform_populate Date: Fri, 10 Jun 2011 17:44:47 -0500 Message-ID: <4DF29E5F.8030307@gmail.com> References: <1307738923-7564-1-git-send-email-robherring2@gmail.com> <1307738923-7564-3-git-send-email-robherring2@gmail.com> <20110610213756.GC28994@ponder.secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110610213756.GC28994-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Grant Likely Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 06/10/2011 04:37 PM, Grant Likely wrote: > On Fri, Jun 10, 2011 at 03:48:41PM -0500, Rob Herring wrote: >> From: Rob Herring >> >> of_platform_populate is missing an EXPORT_SYMBOL, so add it. >> >> Cc: Grant Likely >> Signed-off-by: Rob Herring >> --- >> drivers/of/platform.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/of/platform.c b/drivers/of/platform.c >> index dc56a77..8d0f477 100644 >> --- a/drivers/of/platform.c >> +++ b/drivers/of/platform.c >> @@ -328,4 +328,5 @@ int of_platform_populate(struct device_node *root, >> of_node_put(root); >> return rc; >> } >> +EXPORT_SYMBOL(of_platform_populate); > > I hadn't done this because I hadn't seen a need for calling it from > module code. Do you have a driver that uses it? > No, but then it doesn't appear that other functions in this file are used by modules either. Only of_platform_device_create is used by a module (drivers/macintosh) AFAICT. Either way, it doesn't really matter to me. Rob