Re: [PATCH v5] drivers/amba: create devices from device tree

[Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On 06/10/2011 06:26 PM, Rob Herring wrote:
> Add a function to create amba_devices (i.e. primecell peripherals)
> from device tree nodes. The device tree scanning is done by the
> of_platform_populate() function which can call of_amba_device_create
> based on a match table entry.
>
> Nodes with a "arm,primecell-periphid" property can override the h/w
> peripheral id value.
>
> Based on the original work by Jeremy Kerr.
>
> v5: - restored Jeremy's original s-o-b line
>      - changed to using arm,primecell compatible value
>      - moved all code to driver/of/platform.c so platform and amba
>        devices are created in the same way.
> (v4 was posted by Rob Herring)
>
> Signed-off-by: Jeremy Kerr<jeremy.kerr-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
> Acked-by: Linus Walleij<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Signed-off-by: Rob Herring<rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
> Reviewed-by: Arnd Bergmann<arnd-r2nGTMty4D4@public.gmane.org>
> [grant.likely: add Jeremy's original s-o-b line, changes from review
>                 comments, and moved all code to drivers/of/platform.c]
> Signed-off-by: Grant Likely<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> ---
>
> Hey Rob.  I took a good look at the patches you posted, and how all
> this stuff was being done, and it turns out to be a lot less impact if
> all of it is rolled into driver/of/platform.c.  Take a look and let me
> know what you think.

Looks good. I will test it out on my tree.

Rob