From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH] dt: add helper to read 64-bit integers Date: Tue, 02 Aug 2011 14:16:37 -0500 Message-ID: <4E384D15.4020303@gmail.com> References: <1312283219-27045-1-git-send-email-jamie@jamieiles.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1312283219-27045-1-git-send-email-jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Jamie Iles Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org Jamie, On 08/02/2011 06:06 AM, Jamie Iles wrote: > Add a helper similar to of_property_read_u32() that handles 64-bit > integers. > > Cc: Grant Likely > Signed-off-by: Jamie Iles > --- > drivers/of/base.c | 28 ++++++++++++++++++++++++++++ > include/linux/of.h | 8 ++++++++ > 2 files changed, 36 insertions(+), 0 deletions(-) > > diff --git a/drivers/of/base.c b/drivers/of/base.c > index 02ed367..bae5161 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -631,6 +631,34 @@ int of_property_read_u32_array(const struct device_node *np, char *propname, > EXPORT_SYMBOL_GPL(of_property_read_u32_array); > > /** > + * of_property_read_u64 - Find and read a 64 bit integer from a property > + * @np: device node from which the property value is to be read. > + * @propname: name of the property to be searched. > + * @out_value: pointer to return value, modified only if return value is 0. > + * > + * Search for a property in a device node and read a 64-bit value from > + * it. Returns 0 on success, -EINVAL if the property does not exist, > + * -ENODATA if property does not have a value, and -EOVERFLOW if the > + * property data isn't large enough. > + * > + * The out_value is modified only if a valid u64 value can be decoded. > + */ > +int of_property_read_u64(struct device_node *np, char *propname, u64 *out_value) First 2 params should have a const. Rob > +{ > + struct property *prop = of_find_property(np, propname, NULL); > + > + if (!prop) > + return -EINVAL; > + if (!prop->value) > + return -ENODATA; > + if (sizeof(*out_value) > prop->length) > + return -EOVERFLOW; > + *out_value = of_read_number(prop->value, 2); > + return 0; > +} > +EXPORT_SYMBOL_GPL(of_property_read_u64); > + > +/** > * of_property_read_string - Find and read a string from a property > * @np: device node from which the property value is to be read. > * @propname: name of the property to be searched. > diff --git a/include/linux/of.h b/include/linux/of.h > index bd716f8..9fde908 100644 > --- a/include/linux/of.h > +++ b/include/linux/of.h > @@ -199,6 +199,8 @@ extern int of_property_read_u32_array(const struct device_node *np, > char *propname, > u32 *out_values, > size_t sz); > +extern int of_property_read_u64(struct device_node *np, char *propname, > + u64 *out_value); > > extern int of_property_read_string(struct device_node *np, char *propname, > const char **out_string); > @@ -253,6 +255,12 @@ static inline int of_property_read_string(struct device_node *np, > return -ENOSYS; > } > > +static inline int of_property_read_u64(struct device_node *np, char *propname, > + u64 *out_value) > +{ > + return -ENOSYS; > +} > + > #endif /* CONFIG_OF */ > > static inline int of_property_read_u32(const struct device_node *np,