From: Scott Wood <scottwood@freescale.com>
To: Robin Holt <holt@sgi.com>
Cc: Kumar Gala <galak@kernel.crashing.org>,
Wolfgang Grandegger <wg@grandegger.com>,
U Bhaskar-B22300 <B22300@freescale.com>,
Grant Likely <grant.likely@secretlab.ca>,
Marc Kleine-Budde <mkl@pengutronix.de>,
socketcan-core@lists.berlios.de, netdev@vger.kernel.org,
PPC list <linuxppc-dev@lists.ozlabs.org>,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding.
Date: Wed, 10 Aug 2011 11:56:28 -0500 [thread overview]
Message-ID: <4E42B83C.2040705@freescale.com> (raw)
In-Reply-To: <1312993670-23999-6-git-send-email-holt@sgi.com>
On 08/10/2011 11:27 AM, Robin Holt wrote:
> -CPI Clock- Can Protocol Interface Clock
> - This CLK_SRC bit of CTRL(control register) selects the clock source to
> - the CAN Protocol Interface(CPI) to be either the peripheral clock
> - (driven by the PLL) or the crystal oscillator clock. The selected clock
> - is the one fed to the prescaler to generate the Serial Clock (Sclock).
> - The PRESDIV field of CTRL(control register) controls a prescaler that
> - generates the Serial Clock (Sclock), whose period defines the
> - time quantum used to compose the CAN waveform.
> +- compatible : Should be "fsl,flexcan" and optionally
> + "fsl,flexcan-<processor>"
fsl,<processor>-flexcan, and it should not be optional, and should come
before "fsl,flexcan".
Also may want to list fsl,p1010-rdb as a "canonical compatible" for
anything which is backwards compatible with p1010's implementation.
-Scott
next prev parent reply other threads:[~2011-08-10 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1312993670-23999-1-git-send-email-holt@sgi.com>
[not found] ` <1312993670-23999-1-git-send-email-holt-sJ/iWh9BUns@public.gmane.org>
2011-08-10 16:27 ` [PATCH v11 3/5] flexcan: Add of_match to platform_device definition Robin Holt
2011-08-10 16:27 ` [PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding Robin Holt
2011-08-10 16:56 ` Scott Wood [this message]
[not found] ` <4E42B83C.2040705-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-08-10 17:19 ` Robin Holt
2011-08-10 17:36 ` Scott Wood
[not found] ` <4E42C196.7030708-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-08-10 18:30 ` Robin Holt
2011-08-10 18:40 ` Scott Wood
[not found] ` <4E42D09E.4080405-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-08-10 18:45 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E42B83C.2040705@freescale.com \
--to=scottwood@freescale.com \
--cc=B22300@freescale.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=galak@kernel.crashing.org \
--cc=grant.likely@secretlab.ca \
--cc=holt@sgi.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan-core@lists.berlios.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).