devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Cousson, Benoit" <b-cousson@ti.com>
To: "G, Manjunath Kondaiah" <manjugk@ti.com>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	linux-omap <linux-omap@vger.kernel.org>,
	linux-arm-kernel@lis
Subject: Re: [RFC/PATCH v2 10/13] dt: omap4: panda board: set clock freq for i2c devices
Date: Tue, 23 Aug 2011 21:03:55 +0200	[thread overview]
Message-ID: <4E53F99B.3060308@ti.com> (raw)
In-Reply-To: <4E537F6B.4060608@ti.com>

> From: G, Manjunath Kondaiah<manjugk@ti.com>
> To: devicetree-discuss@lists.ozlabs.org
> CC: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
>
>
> Update omap4 panda dts file with required clock frequencies
> for the i2c client devices existing on panda board.
>
> Signed-off-by: G, Manjunath Kondaiah<manjugk@ti.com>
> ---
>    arch/arm/boot/dts/omap4-panda.dts |   16 ++++++++++++++++
>    1 files changed, 16 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap4-panda.dts
> b/arch/arm/boot/dts/omap4-panda.dts
> index c28aa95..6b831ca 100644
> --- a/arch/arm/boot/dts/omap4-panda.dts
> +++ b/arch/arm/boot/dts/omap4-panda.dts
> @@ -3,4 +3,20 @@
>    / {
>    	model = "TI OMAP4 PandaBoard";
>    	compatible = "ti,omap4-panda", "ti,omap4430";
> +
> +	i2c1 {
> +		clock-frequency =<400000>;
> +	};
> +
> +	i2c2 {
> +		clock-frequency =<400000>;
> +	};
> +
> +	i2c3 {
> +		clock-frequency =<400000>;
> +	};
> +
> +	i2c4 {
> +		clock-frequency =<400000>;
> +	};
>    };

Are you sure that this patch is setting the expected frequency?
I see 100kHz in the boot log even with that patch.

I took me some time to find the proper syntax, but in order to reference 
an existing node, you have to use &i2c1 at the top level of the file. If 
you check the output of the DTC compiler, you will see the property at 
the proper node.

Benoit


  parent reply	other threads:[~2011-08-23 19:03 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-23  5:03 [RFC/PATCH v2 00/13] dt: omap: dt binding with omap_device and support for i2c1 G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 01/13] OMAP: omap_device: Add device tree node pointer G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 02/13] dt: Add pd_size to AUXDATA structure G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 03/13] dt: omap3: add soc file for handling i2c controllers G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 04/13] dt: omap3: beagle board: set clock freq for i2c devices G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 05/13] dt: omap3: add generic board file for dt support G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 06/13] dt: omap3: add omap-device compatible property G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 07/13] dt: omap: create platform bus for omap devices G, Manjunath Kondaiah
2011-08-23  9:07   ` Jamie Iles
2011-08-23 15:19     ` G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 08/13] dt: omap: i2c: add dt support for i2c1 controller G, Manjunath Kondaiah
2011-08-23 15:46   ` G, Manjunath Kondaiah
2011-09-01 17:34     ` Cousson, Benoit
2011-09-02  3:22       ` G, Manjunath Kondaiah
     [not found]   ` <4E537F53.4030405@ti.com>
2011-08-23 19:15     ` Fwd: " Cousson, Benoit
2011-08-23  5:03 ` [RFC/PATCH v2 09/13] dt: omap4: add soc file for handling i2c controllers G, Manjunath Kondaiah
2011-08-23  8:23   ` Rajendra Nayak
2011-08-23 15:11     ` G, Manjunath Kondaiah
     [not found]   ` <4E537FA7.3050609@ti.com>
2011-08-23 13:48     ` Fwd: " Cousson, Benoit
2011-08-23 15:18       ` G, Manjunath Kondaiah
2011-08-23 19:45         ` Cousson, Benoit
2011-08-23  5:03 ` [RFC/PATCH v2 10/13] dt: omap4: panda board: set clock freq for i2c devices G, Manjunath Kondaiah
     [not found]   ` <4E537F6B.4060608@ti.com>
2011-08-23 19:03     ` Cousson, Benoit [this message]
2011-08-23 19:15       ` G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 11/13] dt: omap4: add generic board file for dt support G, Manjunath Kondaiah
     [not found]   ` <4E537F80.1060001@ti.com>
     [not found]     ` <4E537F80.1060001-l0cyMroinI0@public.gmane.org>
2011-08-23 13:05       ` Fwd: " Cousson, Benoit
2011-08-23 15:30         ` G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 12/13] dt: omap4: enable dt support for i2c1 controller G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 13/13] dt: omap: i2c: dt usage model documentation G, Manjunath Kondaiah
     [not found] ` <4E537ECB.1060704@ti.com>
2011-08-23 12:38   ` [RFC/PATCH v2 00/13] dt: omap: dt binding with omap_device and support for i2c1 Cousson, Benoit
2011-08-23 15:41 ` G, Manjunath Kondaiah
2011-08-24  9:41   ` Cousson, Benoit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E53F99B.3060308@ti.com \
    --to=b-cousson@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linux-arm-kernel@lis \
    --cc=linux-omap@vger.kernel.org \
    --cc=manjugk@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).