devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Cousson, Benoit" <b-cousson@ti.com>
To: Rob Herring <robherring2@gmail.com>
Cc: "grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
	"Hilman, Kevin" <khilman@ti.com>,
	"G, Manjunath Kondaiah" <manjugk@ti.com>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH 2/7] arm/dts: Add initial device tree support for OMAP4 SoC
Date: Thu, 25 Aug 2011 15:57:34 +0200	[thread overview]
Message-ID: <4E5654CE.4000303@ti.com> (raw)
In-Reply-To: <4E565004.9050806@gmail.com>

Hi Rob,

On 8/25/2011 3:37 PM, Rob Herring wrote:
> Benoit,

[...]

>> +		gic: interrupt-controller@48241000 {
>> +			compatible = "ti,omap4-gic", "arm,gic";
>
> The gic binding is still being hashed out. This needs binding
> documentation and handling of PPIs. I'm planning on posting an updated
> series today with this.
>
> "arm,gic" should be dropped or replaced with "arm,cortex-a9-gic".
> Non-specific DT bindings are not well received. Is OMAP4 gic different
> from standard Cortex-A9?

Not at all. We named it like that based on Grant's comment:
http://permalink.gmane.org/gmane.linux.ports.arm.omap/60393

I'll update it with the new binding.

>> +			interrupt-controller;
>> +			#interrupt-cells =<1>;
>> +			reg =<0x48241000 0x1000>,
>> +			<0x48240100 0x0200>;
>
> Isn't the cpu interface register space 0x100 bytes long?

I've just checked the spec, and this is indeed 256 bytes. I'll fix that.

Thanks for the comments.

Regards,
Benoit


  reply	other threads:[~2011-08-25 13:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-24 10:17 [RFC PATCH 0/7] OMAP: Add initial support for DT on OMAP4 Benoit Cousson
2011-08-24 10:17 ` [RFC PATCH 1/7] OMAP3+: boards: Fix the __initconst build error Benoit Cousson
2011-08-24 10:17 ` [RFC PATCH 2/7] arm/dts: Add initial device tree support for OMAP4 SoC Benoit Cousson
2011-08-25 13:37   ` Rob Herring
2011-08-25 13:57     ` Cousson, Benoit [this message]
2011-08-24 10:17 ` [RFC PATCH 3/7] arm/dts: Update OMAP4 Panda to include common omap4.dtsi Benoit Cousson
2011-08-24 10:17 ` [RFC PATCH 4/7] arm/dts: Add support for OMAP4 SDP board Benoit Cousson
2011-08-24 10:17 ` [RFC PATCH 5/7] OMAP4: board-panda: Remove DT support from regular board Benoit Cousson
2011-08-24 10:17 ` [RFC PATCH 6/7] OMAP4: board-dt: Add generic board with DT support Benoit Cousson
2011-08-24 10:17 ` [RFC PATCH 7/7] documentation/dt: Add OMAP bindings Benoit Cousson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E5654CE.4000303@ti.com \
    --to=b-cousson@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=manjugk@ti.com \
    --cc=robherring2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).