From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Cousson, Benoit" Subject: Re: [RFC PATCH 05/10] documentation/dt: Add mpu, dsp and iva bindings Date: Fri, 9 Sep 2011 02:30:24 +0200 Message-ID: <4E695E20.5070506@ti.com> References: <1314191356-10963-1-git-send-email-b-cousson@ti.com> <1314191356-10963-6-git-send-email-b-cousson@ti.com> <20110908180910.GE2967@ponder.secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110908180910.GE2967@ponder.secretlab.ca> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Grant Likely Cc: "Hilman, Kevin" , "tony@atomide.com" , "G, Manjunath Kondaiah" , "devicetree-discuss@lists.ozlabs.org" , Randy Dunlap , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On 9/8/2011 8:09 PM, Grant Likely wrote: > On Wed, Aug 24, 2011 at 03:09:11PM +0200, Benoit Cousson wrote: >> Add documentation for the OMAP4 processors bindings. >> >> Signed-off-by: Benoit Cousson >> Cc: Randy Dunlap >> --- >> Documentation/devicetree/bindings/arm/omap/dsp.txt | 14 ++++++++ >> Documentation/devicetree/bindings/arm/omap/iva.txt | 18 ++++++++++ >> Documentation/devicetree/bindings/arm/omap/mpu.txt | 35 ++++++++++++++++++++ >> 3 files changed, 67 insertions(+), 0 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/arm/omap/dsp.txt >> create mode 100644 Documentation/devicetree/bindings/arm/omap/iva.txt >> create mode 100644 Documentation/devicetree/bindings/arm/omap/mpu.txt >> >> diff --git a/Documentation/devicetree/bindings/arm/omap/dsp.txt b/Documentation/devicetree/bindings/arm/omap/dsp.txt >> new file mode 100644 >> index 0000000..8fcd82c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/omap/dsp.txt >> @@ -0,0 +1,14 @@ >> +* TI - DSP (Digital Signal Processor) >> + >> +TI DSP included in OMAP SoC >> + >> +Required properties: >> +- compatible : Should be "ti,c64" for OMAP3& 4 >> +- hwmods: "dsp" >> + >> +Examples: >> + >> +dsp { >> + compatible = "ti,omap4-c64", "ti,c64"; >> + hwmods = "dsp"; >> +}; >> diff --git a/Documentation/devicetree/bindings/arm/omap/iva.txt b/Documentation/devicetree/bindings/arm/omap/iva.txt >> new file mode 100644 >> index 0000000..f428e88 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/omap/iva.txt >> @@ -0,0 +1,18 @@ >> +* TI - IVA (Imaging and Video Accelerator) subsystem >> + >> +The IVA contain various audio, video or imaging HW accelerator >> +depending of the version. >> + >> +Required properties: >> +- compatible : Should be: >> + - "ti,ivahd", "ti,iva" for OMAP4 >> + - "ti,iva2", "ti,iva" for OMAP3 >> + - "ti,iva1", "ti,iva" for OMAP2 > > Again, be specific to the instantiation and encode the omap version > into the compatible value. Use the form "ti,omap4-*", etc. In that case, I do not necessarily agree. The IVA is a generic TI IP used in various chips. The IP version is well documented in the TRM. OK, in fact I didn't pick the proper version:-( It should be: + - "ti,ivahd", for OMAP4 + - "ti,iva2.2", for OMAP3 + - "ti,iva2.1", for OMAP2430 + - "ti,iva1", for OMAP2420 But still, no need to rely on OMAP version to identify the IVA version. Benoit