From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Cousson, Benoit" Subject: Re: [PATCH 02/13] gpio/omap: Adapt GPIO driver to DT Date: Fri, 30 Sep 2011 13:53:10 +0200 Message-ID: <4E85ADA6.2000001@ti.com> References: <1317055821-20652-1-git-send-email-b-cousson@ti.com> <1317055821-20652-3-git-send-email-b-cousson@ti.com> <4E8161C7.7020404@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4E8161C7.7020404@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: "Nayak, Rajendra" Cc: "Hilman, Kevin" , "paul@pwsan.com" , "tony@atomide.com" , "devicetree-discuss@lists.ozlabs.org" , "grant.likely@secretlab.ca" , "linux-omap@vger.kernel.org" , "DebBarma, Tarun Kanti" , "linux-arm-kernel@lists.infradead.org" , "Varadarajan, Charulatha" List-Id: devicetree@vger.kernel.org Second thought... I was too fast to say OK :-) On 9/27/2011 7:40 AM, Nayak, Rajendra wrote: > On Monday 26 September 2011 10:20 PM, Benoit Cousson wrote: [...] >> + if (match) { >> + of_property_read_u32(node, "bank-width",&bank->width); > > Bank width should be u32. I guess you meant bank->width, and it appears that bank->width is already a u32. Regards, Benoit