devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/2] ARM: Samsung: Add Exynos4 device tree enabled board file
Date: Fri, 14 Oct 2011 07:22:15 -0500	[thread overview]
Message-ID: <4E982977.7000305@gmail.com> (raw)
In-Reply-To: <000201cc8a64$6775ae30$36610a90$%kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

On 10/14/2011 06:28 AM, Kukjin Kim wrote:


>>> diff --git a/arch/arm/mach-exynos4/Kconfig
> b/arch/arm/mach-exynos4/Kconfig
>>> index 0c5888a..39dc135 100644
>>> --- a/arch/arm/mach-exynos4/Kconfig
>>> +++ b/arch/arm/mach-exynos4/Kconfig
>>> @@ -304,6 +304,20 @@ config MACH_SMDK4412
>>>  	help
>>>  	  Machine support for Samsung SMDK4412
>>>
>>> +comment "Flattened Device Tree based board for Exynos4 based SoC"
>>> +
>>> +config MACH_EXYNOS4_DT
> 
> I'm not sure we can use 'MACH_EXYNOS4_DT' here because there are other
> EXYNOS4 SoCs such as EXYNOS4212 and EXYNOS4412. So if this cannot support
> other SoCs' boards, SMDK4212 and SMDK4412, we need to change the name.
> 
> And I wonder whether there is no problem with selecting this and other
> boards.

I think this should be fine assuming most things are common. Generally,
the differences can be handled by different DT's. The board compatible
string can be used to handle differences.

Rob

  parent reply	other threads:[~2011-10-14 12:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-11 14:13 [PATCH 0/2] ARM: Samsung: Add basic device tree support for Exynos4 boards Thomas Abraham
2011-10-11 14:13 ` [PATCH 1/2] ARM: Samsung: Add Exynos4 device tree enabled board file Thomas Abraham
2011-10-13 17:51   ` Grant Likely
2011-10-14 11:28     ` Kukjin Kim
     [not found]       ` <000201cc8a64$6775ae30$36610a90$%kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2011-10-14 12:22         ` Rob Herring [this message]
2011-10-11 14:13 ` [PATCH 2/2] ARM: dts: Add intial dts file for Exynos4210 SoC, SMDKV310 and Origen board Thomas Abraham
2011-10-13 17:52   ` Grant Likely
2011-10-14 11:29     ` Kukjin Kim
2011-10-24 13:02 ` [PATCH 0/2] ARM: Samsung: Add basic device tree support for Exynos4 boards Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E982977.7000305@gmail.com \
    --to=robherring2-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).