From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [PATCH V3 1/2] ARM: at91: dt: at91sam9g45 family and board device tree files Date: Mon, 24 Oct 2011 16:32:37 +0200 Message-ID: <4EA57705.6060103@atmel.com> References: <4E9F8226.4030503@gmail.com> <15ab652499e7f6f8a26724bfd90643a8f3f96ad9.1319464310.git.nicolas.ferre@atmel.com> <20111024141253.GF26649@sapphire.tkos.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20111024141253.GF26649@sapphire.tkos.co.il> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Baruch Siach Cc: devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, grant.likely@secretlab.ca, plagnioj@jcrosoft.com, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 10/24/2011 04:12 PM, Baruch Siach : > Hi Nicolas, > > On Mon, Oct 24, 2011 at 04:05:00PM +0200, Nicolas Ferre wrote: >> Create a new device tree source file for Atmel at91sam9g45 SoC family. >> The Evaluation Kit at91sam9m10g45ek includes it. >> This first basic support will be populated as drivers and boards will be >> converted to device tree. >> Contains serial, dma and interrupt controllers. >> >> The generic board file still takes advantage of platform data for early serial >> init. As we need a storage media and the NAND flash driver is not converted to >> DT yet, we keep old initialization for it. >> >> Signed-off-by: Nicolas Ferre >> --- > > [snip] > >> +DT_MACHINE_START(at91sam9m10g45ek_dt, "Atmel AT91SAM (Device Tree)") > > Since this is a generic AT91 machine descriptor, won't "at91sam_dt" be a more > appropriate name? For sure that makes sense. I queue this change and make it appear only in the pull request if it is the only change requested. >> + /* Maintainer: Atmel */ >> + .timer = &at91sam926x_timer, >> + .map_io = at91_map_io, >> + .init_early = ek_init_early, >> + .init_irq = at91_dt_init_irq, >> + .init_machine = at91_dt_device_init, >> + .dt_compat = at91_dt_board_compat, >> +MACHINE_END > > baruch Thanks for your review, Best regards, -- Nicolas Ferre