Devicetree
 help / color / mirror / Atom feed
From: "Cousson, Benoit" <b-cousson@ti.com>
To: Igor Grinberg <grinberg@compulab.co.il>
Cc: Ilya Yanok <yanok@emcraft.com>,
	linux-omap@vger.kernel.org, wd@denx.de, dzu@denx.de,
	sasha_d@emcraft.com,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>
Subject: Re: [PATCH 3/4] dts/omap3: split omap3.dtsi
Date: Thu, 10 Nov 2011 18:09:08 +0100	[thread overview]
Message-ID: <4EBC0534.4020306@ti.com> (raw)
In-Reply-To: <4EBBC10B.6070206@compulab.co.il>

+ devicetree ml

On 11/10/2011 1:18 PM, Igor Grinberg wrote:
> Hi Ilya,
>
> On 11/09/11 02:12, Ilya Yanok wrote:
>> Split omap3.dtsi file into common part, OM3xxx specific part and
>> AM35xx specific part. For now the only difference is missing IVA node on
>> AM35xx.
>>
>> Signed-off-by: Ilya Yanok<yanok@emcraft.com>
>> ---
>>   arch/arm/boot/dts/am35xx.dtsi      |   15 +++++++++++++++
>>   arch/arm/boot/dts/om3xxx.dtsi      |   28 ++++++++++++++++++++++++++++
>>   arch/arm/boot/dts/omap3-beagle.dts |    2 +-
>>   arch/arm/boot/dts/omap3.dtsi       |    9 ---------
>>   4 files changed, 44 insertions(+), 10 deletions(-)
>>   create mode 100644 arch/arm/boot/dts/am35xx.dtsi
>>   create mode 100644 arch/arm/boot/dts/om3xxx.dtsi
>
> om3xxx name is confusing - I haven't seen this name
> in any documentation/code before...
> Am I missing something?
>
> What do you think of omap3-iva.dtsi or omap3-dsp.dtsi?

Cannot we avoid at all hacking the original file and use instead the 
status = "disabled" field for any variant that will not have the 
functionality?

It will be a nightmare for us to maintain a consistent OMAP3 file if 
every variants force us to change the original file.

Regards,
Benoit

       reply	other threads:[~2011-11-10 17:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1320797568-11169-1-git-send-email-yanok@emcraft.com>
     [not found] ` <1320797568-11169-4-git-send-email-yanok@emcraft.com>
     [not found]   ` <4EBBC10B.6070206@compulab.co.il>
2011-11-10 17:09     ` Cousson, Benoit [this message]
2011-11-10 17:26       ` [PATCH 3/4] dts/omap3: split omap3.dtsi Igor Grinberg
2011-11-10 18:07         ` Cousson, Benoit
2011-11-11  7:32           ` Igor Grinberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EBC0534.4020306@ti.com \
    --to=b-cousson@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=dzu@denx.de \
    --cc=grinberg@compulab.co.il \
    --cc=linux-omap@vger.kernel.org \
    --cc=sasha_d@emcraft.com \
    --cc=wd@denx.de \
    --cc=yanok@emcraft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox