From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH] mach-ux500: add devicetree compat nodes Date: Fri, 11 Nov 2011 09:17:25 -0600 Message-ID: <4EBD3C85.1010508@gmail.com> References: <1321023902-18870-1-git-send-email-niklas.hernaeus@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1321023902-18870-1-git-send-email-niklas.hernaeus-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Niklas Hernaeus Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Nicolas.Pitre.nicolas.pitre-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Grant.Likely.grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 11/11/2011 09:05 AM, Niklas Hernaeus wrote: > From: Linus Walleij > > This adds devicetree compat members to all the U8500 reference > boards. > > Signed-off-by: Linus Walleij > --- > arch/arm/mach-ux500/board-mop500.c | 18 ++++++++++++++++++ > 1 files changed, 18 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-ux500/board-mop500.c b/arch/arm/mach-ux500/board-mop500.c > index cd54aba..7cbefa7 100644 > --- a/arch/arm/mach-ux500/board-mop500.c > +++ b/arch/arm/mach-ux500/board-mop500.c > @@ -643,6 +643,21 @@ static void __init mop500_init_machine(void) > regulator_has_full_constraints(); > } > > +static const char * mop500_dt_board_compat[] = { > + "stericsson,mop500", > + NULL > +}; > + > +static const char * hrefv60_dt_board_compat[] = { > + "stericsson,hrefv60", > + NULL > +}; > + > +static const char * snowball_dt_board_compat[] = { > + "stericsson,snowball", > + NULL > +}; > + > MACHINE_START(U8500, "ST-Ericsson MOP500 platform") > /* Maintainer: Srinidhi Kasagar */ > .boot_params = 0x100, > @@ -651,6 +666,7 @@ MACHINE_START(U8500, "ST-Ericsson MOP500 platform") > /* we re-use nomadik timer here */ > .timer = &ux500_timer, > .init_machine = mop500_init_machine, > + .dt_compat = mop500_dt_board_compat, > MACHINE_END > > MACHINE_START(HREFV60, "ST-Ericsson U8500 Platform HREFv60+") > @@ -659,6 +675,7 @@ MACHINE_START(HREFV60, "ST-Ericsson U8500 Platform HREFv60+") > .init_irq = ux500_init_irq, > .timer = &ux500_timer, > .init_machine = mop500_init_machine, > + .dt_compat = hrefv60_dt_board_compat, > MACHINE_END > > MACHINE_START(SNOWBALL, "Calao Systems Snowball platform") > @@ -668,4 +685,5 @@ MACHINE_START(SNOWBALL, "Calao Systems Snowball platform") > /* we re-use nomadik timer here */ > .timer = &ux500_timer, > .init_machine = mop500_init_machine, > + .dt_compat = snowball_dt_board_compat, > MACHINE_END These all look very similar and should be combined. Why do you not have 1 machine for all DT platforms as other SOCs are doing? Rob