From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Shawn Guo <shawn.guo@freescale.com>,
Grant Likely <grant.likely@secretlab.ca>,
devicetree-discuss@lists.ozlabs.orgdevicetree-discuss@lists.ozlabs.org
Cc: "'linux-arm-kernel@lists.infradead.org'"
<linux-arm-kernel@lists.infradead.org>,
netdev@vger.kernel.org, Rob Herring <robherring2@gmail.com>
Subject: Re: [PATCH v2 1/3] dt/net: add helper function of_get_phy_mode
Date: Mon, 21 Nov 2011 11:57:32 +0100 [thread overview]
Message-ID: <4ECA2E9C.1000207@atmel.com> (raw)
Hi all,
> It adds the helper function of_get_phy_mode getting phy interface
> from device tree.
>
> Signed-off-by: Shawn Guo <shawn.guo <at> linaro.org>
> Cc: Grant Likely <grant.likely <at> secretlab.ca>
> ---
> drivers/of/of_net.c | 43 +++++++++++++++++++++++++++++++++++++++++++
> include/linux/of_net.h | 1 +
[..]
> +const int of_get_phy_mode(struct device_node *np)
Nice helper function, indeed.
> +{
> + const char *pm;
> + int err, i;
> +
> + err = of_property_read_string(np, "phy-mode", &pm);
Just a quick question about the use of the "phy-mode" string:
- I know that it is widely used in drivers
- but, I discovered that in the ePAPR the string mentioned is "phy-connection-type" (6.5.2.2)
- and it is true also that in the very same document, we find the "phy-mode" in the Appendix B1 example...
Why this naming is not consistent (even in ePAPR)?
Best regards,
--
Nicolas Ferre
next reply other threads:[~2011-11-21 10:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 10:57 Nicolas Ferre [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-07-05 15:13 [PATCH v2 0/3] Add device tree probe support for imx fec driver Shawn Guo
2011-07-05 15:13 ` [PATCH v2 1/3] dt/net: add helper function of_get_phy_mode Shawn Guo
2011-07-05 17:35 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECA2E9C.1000207@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=devicetree-discuss@lists.ozlabs.orgdevicetree-discuss \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=robherring2@gmail.com \
--cc=shawn.guo@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).