From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 0/4] Versatile Express DT support Date: Mon, 28 Nov 2011 08:25:12 -0600 Message-ID: <4ED399C8.9080908@gmail.com> References: <1322060508-11298-1-git-send-email-pawel.moll@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1322060508-11298-1-git-send-email-pawel.moll-5wv7dgnIgG8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Pawel Moll Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 11/23/2011 09:01 AM, Pawel Moll wrote: > Hello again, > > This version of the series (hopefully) addresses all the suggestions > made by Dave, Rob and Russell. > > The compatible values are specific for the tiles now and the memory > map variant is defined as a custom property in the motherboard node. > > Tested on V2P-CA9 coretile both with ATAGs and DT and V2P-CA5s with DT. > > All comments, as always, welcomed! > > Pawel > > > > Pawel Moll (4): > ARM: vexpress: Get rid of MMIO_P2V > ARM: vexpress: Add DT support in v2m > ARM: vexpress: Initial RS1 memory map support > ARM: vexpress: DT-based support for CoreTiles Express A5x2 and A9x4 > > Documentation/devicetree/bindings/arm/vexpress | 101 ++++++++ > arch/arm/boot/dts/vexpress-v2m-rs1.dtsi | 192 +++++++++++++++ > arch/arm/boot/dts/vexpress-v2m.dtsi | 191 +++++++++++++++ > arch/arm/boot/dts/vexpress-v2p-ca5s.dts | 132 ++++++++++ > arch/arm/boot/dts/vexpress-v2p-ca9.dts | 146 +++++++++++ > arch/arm/include/asm/hardware/arm_timer.h | 5 + > arch/arm/mach-vexpress/Kconfig | 35 +++ > arch/arm/mach-vexpress/Makefile | 1 + > arch/arm/mach-vexpress/Makefile.boot | 6 + > arch/arm/mach-vexpress/core.h | 21 ++- > arch/arm/mach-vexpress/ct-ca9x4.c | 52 +--- > arch/arm/mach-vexpress/include/mach/ct-ca9x4.h | 13 +- > arch/arm/mach-vexpress/include/mach/debug-macro.S | 37 +++- > arch/arm/mach-vexpress/include/mach/motherboard.h | 58 +++-- > arch/arm/mach-vexpress/include/mach/uncompress.h | 13 +- > arch/arm/mach-vexpress/platsmp.c | 4 +- > arch/arm/mach-vexpress/v2m.c | 265 ++++++++++++++++++--- > arch/arm/mach-vexpress/v2p-ca5s_ca9.c | 115 +++++++++ > 18 files changed, 1272 insertions(+), 115 deletions(-) > create mode 100644 Documentation/devicetree/bindings/arm/vexpress > create mode 100644 arch/arm/boot/dts/vexpress-v2m-rs1.dtsi > create mode 100644 arch/arm/boot/dts/vexpress-v2m.dtsi > create mode 100644 arch/arm/boot/dts/vexpress-v2p-ca5s.dts > create mode 100644 arch/arm/boot/dts/vexpress-v2p-ca9.dts > create mode 100644 arch/arm/mach-vexpress/v2p-ca5s_ca9.c Other than Dave's comments, looks good. For the series: Acked-by: Rob Herring There are a number of compatible strings for various peripherals defined without documentation, but you're not really using them so I think it's fine for now. BTW, I believe Dave said he was going to document some of the primecell peripherals. :) Rob