From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Subject: Re: [PATCH] arm, davinci: configure davinci aemif chipselects through OF Date: Mon, 05 Dec 2011 12:49:04 +0100 Message-ID: <4EDCAFB0.1080009@denx.de> References: <1322991679-20947-1-git-send-email-hs@denx.de> <4EDB68B7.8080609@mvista.com> Reply-To: hs-ynQEQJNshbs@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <4EDB68B7.8080609-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Sergei Shtylyov Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org, Wolfgang Denk , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hello Sergei, Sergei Shtylyov wrote: > Hello. > > On 04-12-2011 13:41, Heiko Schocher wrote: > >> Signed-off-by: Heiko Schocher >> Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org >> Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org >> Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org >> Cc: grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org >> Cc: Sekhar Nori >> Cc: Kevin Hilman >> Cc: Wolfgang Denk > [...] > >> diff --git a/Documentation/devicetree/bindings/arm/davinci/aemif.txt >> b/Documentation/devicetree/bindings/arm/davinci/aemif.txt >> new file mode 100644 >> index 0000000..c9ed551 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/davinci/aemif.txt >> @@ -0,0 +1,85 @@ >> +* Texas Instruments Davinci AEMIF >> + >> +This file provides information, what the device node for the >> +davinci aemifa interface contain. > [...] >> +Example (enbw_cmc board): >> + aemif@60000000 { >> + compatible = "ti,davinci-emifa"; >> + #address-cells = <2>; >> + #size-cells = <1>; >> + reg = <0x68000000 0x80000>; >> + ranges = <2 0 0x60000000 0x02000000 >> + 3 0 0x62000000 0x02000000 >> + 4 0 0x64000000 0x02000000 >> + 5 0 0x66000000 0x02000000>; >> + cs2@0x60000000 { > > 0x shouldn't be included. fixed. >> + compatible = "ti,davinci-cs"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + /* all timings in nanoseconds */ >> + cs = <2>; >> + asize = <1>; >> + ta = <0>; >> + rhold = <7>; >> + rstrobe = <42>; >> + rsetup = <14>; >> + whold = <7>; >> + wstrobe = <42>; >> + wsetup = <14>; >> + ew = <0>; >> + ss = <0>; >> + }; >> + flash@2,0 { > > Why you have one kind of address for cs2@60000000 node and other kind > for this node? Typo it must be cs2@68000010 { [...] } As the chipselect registers start @0x68000000 maybe I should add in ranges a "x 0 0x68000000 0x00080000" line? But which value has x, as this range has no chipselect? So I could add subnodes "cs2@680000yy" with a reg entry "reg = ;" with yy = offset from 0x68000000 and drop the "cs" property? Or are the "ti,davinci-cs" nodes no subnodes from "ti,davinci-emifa", so I easy can use "reg = <0x68000010 4>;"? bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany