From: Rob Herring <robherring2@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: pawel.moll@arm.com, linux-ide@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, jgarzik@redhat.com,
rob.herring@calxeda.com
Subject: Re: pata_of_platform.c cannot build on sparc
Date: Wed, 21 Dec 2011 17:25:15 -0600 [thread overview]
Message-ID: <4EF26ADB.2040504@gmail.com> (raw)
In-Reply-To: <20111221.173810.971054965060472866.davem@davemloft.net>
On 12/21/2011 04:38 PM, David Miller wrote:
>
> It depends upon CONFIG_OF_IRQ which not all CONFIG_OF platforms support,
> in particular sparc does not support CONFIG_OF_PLATFORM because it
> precomputes all IRQs at boot time when it scans the device tree so all
> of the CONFIG_OF_IRQ infrastructure to probe and resolve IRQs at driver
> probe time is wrong and completely unnecessary.
>
> Add the proper dependencies so that pata_of_platform.c doesn't get
> built on sparc.
>
> CONFIG_OF_IRQ was severely misdesigned, it should just NOP out on
> platforms where the architecture has the final IRQ values already like
> sparc does. But that's not how it was implemented at all, and now
> we're starting to have all of these drivers get hard dependencies on
> this mechanism and it's datastructures, and the resulting sparc build
> failures from time to time.
>
> Jeff, please push something like the following to Linus so that
> sparc's allmodconfig builds again. Thanks.
>
Really, drivers should no longer use of_irq_to_resource (or
of_address_to_resource for that matter). The resources are setup by the
core OF code. The patch I sent does this.
Rob
> --------------------
> pata_of_platform: Add missing CONFIG_OF_IRQ dependency.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 6bdedd7..cf047c4 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -820,7 +820,7 @@ config PATA_PLATFORM
>
> config PATA_OF_PLATFORM
> tristate "OpenFirmware platform device PATA support"
> - depends on PATA_PLATFORM && OF
> + depends on PATA_PLATFORM && OF && OF_IRQ
> help
> This option enables support for generic directly connected ATA
> devices commonly found on embedded systems with OpenFirmware
> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss
next prev parent reply other threads:[~2011-12-21 23:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 22:38 pata_of_platform.c cannot build on sparc David Miller
2011-12-21 23:23 ` [PATCH] pata_of_platform: remove direct dependency on OF_IRQ Rob Herring
2011-12-21 23:25 ` Rob Herring [this message]
2011-12-22 0:14 ` pata_of_platform.c cannot build on sparc David Miller
2011-12-22 1:40 ` Jeff Garzik
2011-12-22 13:38 ` Rob Herring
2011-12-22 20:00 ` Sergei Shtylyov
2011-12-22 19:38 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF26ADB.2040504@gmail.com \
--to=robherring2@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=jgarzik@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).