From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH] irqdomain: include linux/bug.h for WARN_ON() Date: Fri, 30 Dec 2011 14:13:59 -0600 Message-ID: <4EFE1B87.6030607@gmail.com> References: <1324333357-3357-1-git-send-email-jamie@jamieiles.com> <20111230200016.GB3427@page> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20111230200016.GB3427@page> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Jamie Iles Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Thomas Gleixner List-Id: devicetree@vger.kernel.org On 12/30/2011 02:00 PM, Jamie Iles wrote: > On Mon, Dec 19, 2011 at 10:22:37PM +0000, Jamie Iles wrote: >> Commit 6d274309d (irq: support domains with non-zero hwirq base) >> introduced a WARN_ON() for an invalid hwirq in irq_domain_to_irq() but >> doesn't include linux/bug.h resulting in: >> >> include/linux/irqdomain.h: In function 'irq_domain_to_irq': >> include/linux/irqdomain.h:78:2: error: implicit declaration of function 'WARN_ON' >> >> if it isn't implicitly pulled in before. >> >> Cc: Rob Herring >> Cc: Grant Likely >> Cc: Thomas Gleixner >> Signed-off-by: Jamie Iles > Applied for 3.3. Rob