* [PATCH] staging:iio: isl29018: add of_match table for device-tree probing
@ 2011-12-23 2:44 Olof Johansson
[not found] ` <1324608283-3128-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Olof Johansson @ 2011-12-23 2:44 UTC (permalink / raw)
To: Jonathan Cameron, Greg Kroah-Hartman
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
linux-iio-u79uwXL29TY76Z2rM5mHXA, Olof Johansson
As simple as can be right now; just one ID and no custom properties to parse.
Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
---
drivers/staging/iio/light/isl29018.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
index 849d6a5..38ec52b 100644
--- a/drivers/staging/iio/light/isl29018.c
+++ b/drivers/staging/iio/light/isl29018.c
@@ -592,11 +592,18 @@ static const struct i2c_device_id isl29018_id[] = {
MODULE_DEVICE_TABLE(i2c, isl29018_id);
+static const struct of_device_id isl29018_of_match[] = {
+ { .compatible = "invn,isl29018", },
+ { },
+};
+MODULE_DEVICE_TABLE(of, isl29018_of_match);
+
static struct i2c_driver isl29018_driver = {
.class = I2C_CLASS_HWMON,
.driver = {
.name = "isl29018",
.owner = THIS_MODULE,
+ .of_match_table = isl29018_of_match,
},
.probe = isl29018_probe,
.remove = __devexit_p(isl29018_remove),
--
1.7.8.GIT
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1324608283-3128-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>]
* Re: [PATCH] staging:iio: isl29018: add of_match table for device-tree probing [not found] ` <1324608283-3128-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org> @ 2011-12-31 18:42 ` Jonathan Cameron 2012-01-02 8:58 ` Grant Likely 1 sibling, 0 replies; 3+ messages in thread From: Jonathan Cameron @ 2011-12-31 18:42 UTC (permalink / raw) To: Olof Johansson Cc: Jonathan Cameron, Greg Kroah-Hartman, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, linux-iio-u79uwXL29TY76Z2rM5mHXA On 12/23/2011 02:44 AM, Olof Johansson wrote: > As simple as can be right now; just one ID and no custom properties to parse. Looks fine to me, but I'm not familiar with device tree naming convensions so wouldn't mind a 'yes, that's right' from someone who is! > > Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org> Acked-by: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > --- > drivers/staging/iio/light/isl29018.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c > index 849d6a5..38ec52b 100644 > --- a/drivers/staging/iio/light/isl29018.c > +++ b/drivers/staging/iio/light/isl29018.c > @@ -592,11 +592,18 @@ static const struct i2c_device_id isl29018_id[] = { > > MODULE_DEVICE_TABLE(i2c, isl29018_id); > > +static const struct of_device_id isl29018_of_match[] = { > + { .compatible = "invn,isl29018", }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, isl29018_of_match); > + > static struct i2c_driver isl29018_driver = { > .class = I2C_CLASS_HWMON, > .driver = { > .name = "isl29018", > .owner = THIS_MODULE, > + .of_match_table = isl29018_of_match, > }, > .probe = isl29018_probe, > .remove = __devexit_p(isl29018_remove), ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging:iio: isl29018: add of_match table for device-tree probing [not found] ` <1324608283-3128-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org> 2011-12-31 18:42 ` Jonathan Cameron @ 2012-01-02 8:58 ` Grant Likely 1 sibling, 0 replies; 3+ messages in thread From: Grant Likely @ 2012-01-02 8:58 UTC (permalink / raw) To: Olof Johansson Cc: Jonathan Cameron, Greg Kroah-Hartman, linux-iio-u79uwXL29TY76Z2rM5mHXA, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ On Thu, Dec 22, 2011 at 06:44:43PM -0800, Olof Johansson wrote: > As simple as can be right now; just one ID and no custom properties to parse. > > Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org> Acked-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> > --- > drivers/staging/iio/light/isl29018.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c > index 849d6a5..38ec52b 100644 > --- a/drivers/staging/iio/light/isl29018.c > +++ b/drivers/staging/iio/light/isl29018.c > @@ -592,11 +592,18 @@ static const struct i2c_device_id isl29018_id[] = { > > MODULE_DEVICE_TABLE(i2c, isl29018_id); > > +static const struct of_device_id isl29018_of_match[] = { > + { .compatible = "invn,isl29018", }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, isl29018_of_match); > + > static struct i2c_driver isl29018_driver = { > .class = I2C_CLASS_HWMON, > .driver = { > .name = "isl29018", > .owner = THIS_MODULE, > + .of_match_table = isl29018_of_match, > }, > .probe = isl29018_probe, > .remove = __devexit_p(isl29018_remove), > -- > 1.7.8.GIT > > _______________________________________________ > devicetree-discuss mailing list > devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org > https://lists.ozlabs.org/listinfo/devicetree-discuss ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-02 8:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-23 2:44 [PATCH] staging:iio: isl29018: add of_match table for device-tree probing Olof Johansson
[not found] ` <1324608283-3128-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2011-12-31 18:42 ` Jonathan Cameron
2012-01-02 8:58 ` Grant Likely
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).