From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Subject: Re: [RFC 1/8] gpio/microblaze: Eliminate duplication of of_get_named_gpio_flags() Date: Thu, 05 Jan 2012 08:28:23 +0100 Message-ID: <4F055117.7060901@monstr.eu> References: <1320801583-12774-1-git-send-email-grant.likely@secretlab.ca> <1320801583-12774-2-git-send-email-grant.likely@secretlab.ca> <4EF1B36A.8050304@monstr.eu> <20120104183057.GU15503@ponder.secretlab.ca> Reply-To: monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120104183057.GU15503-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Grant Likely Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Rob Herring , Sascha Hauer , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Grant Likely wrote: > On Wed, Dec 21, 2011 at 11:22:34AM +0100, Michal Simek wrote: >> Grant Likely wrote: >>> of_reset_gpio_handle() is largely a cut-and-paste copy of >>> of_get_named_gpio_flags(). There really isn't any reason for the >>> split, so this patch deletes the duplicate function >>> >>> Signed-off-by: Grant Likely >>> Cc: Michal Simek >>> --- >>> arch/microblaze/kernel/reset.c | 43 +-------------------------------------- >>> 1 files changed, 2 insertions(+), 41 deletions(-) >> Sorry for taking to long. >> >> Tested and applied to microblaze tree. > > I'd rather take this one through the gpio tree if that is okay. OK. Please do. Thanks, Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian