Re: [PATCH 1/2] mt_ventoux: very basic support for TeeJet Mt.Ventoux board

[Igor Grinberg <grinberg@compulab.co.il>]

Hi Grant,

On 01/04/12 21:54, Grant Likely wrote:
> On Tue, Dec 27, 2011 at 12:08:31AM +0100, Ilya Yanok wrote:
>> Very basic support for TeeJet Mt.Ventoux board. Able to boot via
>> board-generic and ramdisk/initramfs, however most of peripherals are
>> not supported. Produces tons of twl4030 related errors as this board
>> doesn't have twl4030 installed.
>>
>> Signed-off-by: Ilya Yanok <yanok@emcraft.com>
> 
> Comment below, but otherwise:
> 
> Acked-by: Grant Likely <grant.likely@secretlab.ca>

Though nothing fundamentally different in regard to DT, but
there is a v3 of this patch set available at [1]

> 
>> ---
>>  arch/arm/boot/dts/am3517_mt_ventoux.dts |   27 +++++++++++++++++++++++++++
>>  1 files changed, 27 insertions(+), 0 deletions(-)
>>  create mode 100644 arch/arm/boot/dts/am3517_mt_ventoux.dts
>>
>> diff --git a/arch/arm/boot/dts/am3517_mt_ventoux.dts b/arch/arm/boot/dts/am3517_mt_ventoux.dts
>> new file mode 100644
>> index 0000000..5eb26d7
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/am3517_mt_ventoux.dts
>> @@ -0,0 +1,27 @@
>> +/*
>> + * Copyright (C) 2011 Ilya Yanok, EmCraft Systems
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + */
>> +/dts-v1/;
>> +
>> +/include/ "omap3.dtsi"
>> +
>> +/ {
>> +	model = "TeeJet Mt.Ventoux";
>> +	compatible = "teejet,mt_ventoux", "ti,omap3";
>> +
>> +	memory {
>> +		device_type = "memory";
>> +		reg = <0x80000000 0x10000000>; /* 256 MB */
>> +	};
>> +
>> +	/* AM35xx doesn't have IVA */
> 
> Perhaps the AM35xx should have a separate .dtsi file?

In that case there is a possibility you will get multiple
<SoC>.dtsi files with the same copy/pasted "disable" stuff.
Of course this is better than having multiple board files doing this.

What do you think on splitting the whole thing into <IP>.dtsi files,
Like I have explained here [2]?

> 
>> +	soc {
>> +		iva {
>> +			status = "disabled";
>> +		};
>> +	};
>> +};

[1] http://www.spinics.net/lists/linux-omap/msg62185.html
[2] http://www.spinics.net/lists/linux-omap/msg61975.html


-- 
Regards,
Igor.