From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [PATCH v3 3/6] ARM: at91/gpio: add DT support Date: Thu, 05 Jan 2012 18:50:48 +0100 Message-ID: <4F05E2F8.2020609@atmel.com> References: <1325615688-16860-1-git-send-email-nicolas.ferre@atmel.com> <1325792566-32700-1-git-send-email-nicolas.ferre@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1325792566-32700-1-git-send-email-nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org Cc: tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 01/05/2012 08:42 PM, Nicolas Ferre : > From: Jean-Christophe PLAGNIOL-VILLARD > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > Signed-off-by: Nicolas Ferre > Acked-by: Grant Likely > --- > v3: - Corrections proposed by Russell King: > - use of clk_prepare()/clk_unprepare() > - helper function to setup the clock for both DT/non DT init functions Forget this one: a bug has made its home in it... > v2: - no BUG_ON() anymore in case of an "interrupts" property missing > just stop configuring the gpio bank > - review error path in both of_at91_gpio_init_one() and > at91_gpio_init_one() > - use for_each_compatible_node() iterator instead of a homemade loop [..] -- Nicolas Ferre