Re: [PATCH] ARM: vexpress: initial device tree support

[Mitch Bradley <wmb-D5eQfiDGL7eakBO8gow8eQ@public.gmane.org>]

More nits picked below ...


 >
 > i2c1: i2c@7000c000 {
 >      #address-cells =<1>;
 >      #size-cells =<0>;
 >      compatible = "nvidia,tegra20-i2c";
 >      reg =<0x7000C000 0x100>;
 >      interrupts =<0 38 0x04>;
 > };
 >
 > mux@0 {

The name "i2cmux" might be more evocative.

 >      #address-cells =<1>;
 >      #size-cells =<0>;
 >      compatible = "nvidia,tegra20-i2c";
 >      parent-bus =<&i2c1>;
 >      gpios =<&gpio 100 0&gpio 101 0>;
 >      gpio-values-idle =<0>; /* bitmask of values */
 >
 >      bus@0 {

Since this implements the i2c bus abstraction, the name should be "i2c"

 >          #address-cells =<1>;
 >          #size-cells =<0>;
 >          /*
 >           * The GPIO values to set as a bitmask.
 >           * Formatted like gpio-i2cmux.c's mux->data.values[i].
 >           * Or name this gpio-values?
 >           */
 >          reg =<1>;
 >
 >          wm8903: wm8903@1a {
 >              compatible = "wlf,wm8903";
 >              reg =<0x1a>;
 >              ...
 >          };
 >      };
 >
 >      bus@1 {

Ditto, name should be "i2c"

 >          #address-cells =<1>;
 >          #size-cells =<0>;
 >          reg =<2>;
 >
 >          light-sensor@44 {
 >              compatible = "isil,isl29018";
 >              reg =<0x44>;
 >              ...
 >          };
 >      };
 > };