From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH] irqdomain: include linux/bug.h for WARN_ON() Date: Thu, 12 Jan 2012 08:35:12 -0600 Message-ID: <4F0EEFA0.7030808@gmail.com> References: <1324333357-3357-1-git-send-email-jamie@jamieiles.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1324333357-3357-1-git-send-email-jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Jamie Iles Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Thomas Gleixner List-Id: devicetree@vger.kernel.org Jamie, On 12/19/2011 04:22 PM, Jamie Iles wrote: > Commit 6d274309d (irq: support domains with non-zero hwirq base) > introduced a WARN_ON() for an invalid hwirq in irq_domain_to_irq() but > doesn't include linux/bug.h resulting in: > > include/linux/irqdomain.h: In function 'irq_domain_to_irq': > include/linux/irqdomain.h:78:2: error: implicit declaration of function 'WARN_ON' > > if it isn't implicitly pulled in before. > Considering major irqdomain changes are coming, is this really needed? Nothing is currently broken, right? Rob > Cc: Rob Herring > Cc: Grant Likely > Cc: Thomas Gleixner > Signed-off-by: Jamie Iles > --- > include/linux/irqdomain.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h > index fd9815b..0c17b4b 100644 > --- a/include/linux/irqdomain.h > +++ b/include/linux/irqdomain.h > @@ -15,6 +15,7 @@ > #ifndef _LINUX_IRQDOMAIN_H > #define _LINUX_IRQDOMAIN_H > > +#include > #include > > #ifdef CONFIG_IRQ_DOMAIN