devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg-ynQEQJNshbs@public.gmane.org>
To: Richard Retanubun
	<richardretanubun-4VtgCsEi+FIybS5Ee8rs3A@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
	<Devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
Subject: Re: [i2c-mpc.c] adding entry for mpc8360
Date: Fri, 13 Jan 2012 08:26:34 +0100	[thread overview]
Message-ID: <4F0FDCAA.1040203@denx.de> (raw)
In-Reply-To: <4F0EFD78.3020708-4VtgCsEi+FIybS5Ee8rs3A@public.gmane.org>

Hello,

I added the "devicetree-discuss" ml.

On 01/12/2012 04:34 PM, Richard Retanubun wrote:
> Hello,
> 
> I am wondering if it is okay to add .compatible entries for mpc8360 and
> declare its data structure
> to mpc-i2c.c
> 
> something like this:
> 
> {.compatible = "fsl,mpc8360-i2c", .data = &mpc_i2c_data_8360, },
> 
> static struct mpc_i2c_data mpc_i2c_data_8360 __devinitdata = {
>     .setup = mpc_i2c_setup_8xxx,
> };
> 
> or is the intended approach to match the closest thing to your CPU (in
> this case mpc8313) ?

Yes, it is intended to use the name of the compatible device, see:

http://lxr.linux.no/#linux+v3.2.1/arch/powerpc/boot/dts/kmeter1.dts#L69

Wolfgang

       reply	other threads:[~2012-01-13  7:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4F0EFD78.3020708@ruggedcom.com>
     [not found] ` <4F0EFD78.3020708-4VtgCsEi+FIybS5Ee8rs3A@public.gmane.org>
2012-01-13  7:26   ` Wolfgang Grandegger [this message]
     [not found]     ` <4F0FDCAA.1040203-ynQEQJNshbs@public.gmane.org>
2012-01-13 16:05       ` [i2c-mpc.c] adding entry for mpc8360 Richard Retanubun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0FDCAA.1040203@denx.de \
    --to=wg-ynqeqjnshbs@public.gmane.org \
    --cc=Devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=richardretanubun-4VtgCsEi+FIybS5Ee8rs3A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).