From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [RFC PATCH v3 2/5] pinctrl: add dt binding support for pinmux mappings Date: Tue, 17 Jan 2012 13:48:45 -0600 Message-ID: <4F15D09D.3030401@gmail.com> References: <7FE21149F4667147B645348EC6057885075542@039-SN2MPN1-013.039d.mgd.msft.net> <74CDBE0F657A3D45AFBB94109FB122FF176CC743EF@HQMAIL01.nvidia.com> <74CDBE0F657A3D45AFBB94109FB122FF17761F18F8@HQMAIL01.nvidia.com> <7FE21149F4667147B645348EC605788507F698@039-SN2MPN1-013.039d.mgd.msft.net> <74CDBE0F657A3D45AFBB94109FB122FF177EE39E6B@HQMAIL01.nvidia.com> <7FE21149F4667147B645348EC605788508AC65@039-SN2MPN1-013.039d.mgd.msft.net> <74CDBE0F657A3D45AFBB94109FB122FF177EE3A76A@HQMAIL01.nvidia.com> <74CDBE0F657A3D45AFBB94109FB122FF17801D1FAB@HQMAIL01.nvidia.com> <20120114011029.GC1810@S2101-09.ap.freescale.net> <74CDBE0F657A3D45AFBB94109FB122FF17801D22FB@HQMAIL01.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF17801D22FB-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Stephen Warren Cc: "linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org" , "s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org" , "cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Dong Aisheng List-Id: devicetree@vger.kernel.org On 01/17/2012 01:35 PM, Stephen Warren wrote: > Shawn Guo wrote at Friday, January 13, 2012 6:11 PM: >> On Fri, Jan 13, 2012 at 10:33:21AM -0800, Stephen Warren wrote: >>> So of_device_alloc(), which is called by of_platform_populate() for each >>> device, already parses basic DT content such as reg and interrupts, and >>> converts them to Linux resources. I'd consider parsing any pinmux properties >>> and registering them with the pinctrl subsystem to be of a similar nature, >>> so adding some code to of_device_alloc() that calls a core pinmux function >>> to parse the DT node seems reasonable to me. >> >> I hardly believe that device tree maintainers would agree here. >> Grant, Rob? > > I'm explicitly putting Grant and Rob on the To line here to make this > question stand out to them. > But then the same could be argued for regulators, clocks and whatever else infrastructure type bindings we have. I think the distinction here is reg and interrupts are already standard properties of platform_devices. As I believe Linus W said, all the pin mux/ctrl stuff has to work for non-DT as well. So if the infrastructure is handling this for DT, how would this work in the non-DT case? There are already ways to hook into the device creation with bus notifiers. Rob