From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v2 3/7] tegra: fdt: Add extra I2C bindings for U-Boot Date: Thu, 19 Jan 2012 13:51:45 -0700 Message-ID: <4F188261.4060607@nvidia.com> References: <1326394818-32227-1-git-send-email-sjg@chromium.org> <1326394818-32227-4-git-send-email-sjg@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1326394818-32227-4-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Simon Glass Cc: Devicetree Discuss , U-Boot Mailing List , Jerry Van Baren , Tom Warren , Albert ARIBAUD List-Id: devicetree@vger.kernel.org On 01/12/2012 12:00 PM, Simon Glass wrote: > Add U-Boot's peripheral clock information to the Tegra20 device tree file. > diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi > index ca7b523..963cf27 100644 > --- a/arch/arm/dts/tegra20.dtsi > +++ b/arch/arm/dts/tegra20.dtsi > @@ -45,6 +45,8 @@ > compatible = "nvidia,tegra20-i2c"; > reg = <0x7000C000 0x100>; > interrupts = < 70 >; > + clock-frequency = <100000>; That's board-specific information. I'd rather not include it in the SoC .dtsi file even as a default; that way, it forces people to think about the correct value and put it in their board file, whereas including a default means people probably won't think about it. > + clocks = <&periph_clk 12>; // PERIPH_ID_I2C1 Of course, that'll need updating based on the resolution of the clock binding thread I started. -- nvpublic