From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v4 06/20] tegra: fdt: Add Tegra2x device tree file from
 kernel
Date: Thu, 19 Jan 2012 17:06:54 -0700
Message-ID: <4F18B01E.40404@nvidia.com>
References: <1326342789-5781-1-git-send-email-sjg@chromium.org>	<1326342789-5781-7-git-send-email-sjg@chromium.org>	<4F174691.1040007@nvidia.com>
 <CAPnjgZ2Qfuhds3xK=ADiSx_7wprp-AXkreSOhZzPPFe8E54Q=g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
In-Reply-To: <CAPnjgZ2Qfuhds3xK=ADiSx_7wprp-AXkreSOhZzPPFe8E54Q=g@mail.gmail.com>
List-Unsubscribe: <https://lists.ozlabs.org/options/devicetree-discuss>,
 <mailto:devicetree-discuss-request-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/devicetree-discuss>
List-Post: <mailto:devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
List-Help: <mailto:devicetree-discuss-request-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/devicetree-discuss>,
 <mailto:devicetree-discuss-request-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org?subject=subscribe>
Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
To: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: U-Boot Mailing List <u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org>, Devicetree Discuss <devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>, Tom Warren <TWarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>, Jerry Van Baren <vanbaren-He//nVnquyzQT0dZR+AlfA@public.gmane.org>
List-Id: devicetree@vger.kernel.org

On 01/19/2012 04:51 PM, Simon Glass wrote:
> Hi Stephen,
> 
> On Wed, Jan 18, 2012 at 2:24 PM, Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> wrote:
>> On 01/11/2012 09:32 PM, Simon Glass wrote:
>>> This was taken from commit b48c54e2 at:
>>> git://git.kernel.org/pub/scm/linux/kernel/git/olof/tegra.git
>>>
>>> config.mk is updated to provide this file to boards through the
>>> built-in mechanism:
>>>
>>> /include/ ARCH_CPU_DTS
>>>
>>> Signed-off-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>>
>>> diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
>> ...
>>> +     i2c@7000d000 {
>>> +             #address-cells = <1>;
>>> +             #size-cells = <0>;
>>> +             compatible = "nvidia,tegra20-i2c";
>>> +             reg = <0x7000D000 0x200>;
>>> +             interrupts = < 85 >;
>>> +     };
>>
>> This is slightly out-of-date now; in next-20120118, that node's
>> compatible flag is nvidia,tegra20-i2c-dvc. The HW register layout is
>> somewhat different for this I2C controller, and the different compatible
>> flag is how the driver this.
>>
>> Still, you can always apply that fix in a later patch before you add I2C
>> support.
> 
> This series was original submitted 24 November, so of course things
> change. The changes you mention relate to I2C and I think I picked
> these up in the later I2C patches.

As I said, as long as this is updated before the I2C support that relies
on it (as IIRC your I2C patch series did), that's fine.

-- 
nvpublic