From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerry Van Baren Subject: Re: [U-Boot] [PATCH v4 01/20] fdt: Tidy up a few fdtdec problems Date: Sun, 22 Jan 2012 21:03:59 -0500 Message-ID: <4F1CC00F.4030204@gmail.com> References: <1326342789-5781-1-git-send-email-sjg@chromium.org> <1326342789-5781-2-git-send-email-sjg@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1326342789-5781-2-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Simon Glass Cc: U-Boot Mailing List , Devicetree Discuss , Tom Warren , Jerry Van Baren List-Id: devicetree@vger.kernel.org On 01/11/2012 11:32 PM, Simon Glass wrote: > This fixes five trivial issues in fdtdec.c: > 1. fdtdec_get_is_enabled() doesn't really need a default value > 2. The fdt must be word-aligned, since otherwise it will fail on ARM > 3. The compat_names[] array is missing its first element. This is needed > only because the first fdt_compat_id is defined to be invalid. > 4. Added a header prototype for fdtdec_next_compatible() > 5. Change fdtdec_next_alias() to only increment its 'upto' parameter > on success, to make the display error messages in the caller easier. > > Signed-off-by: Simon Glass Acked-by: Gerald Van Baren Thanks, gvb