devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Cousson, Benoit" <b-cousson@ti.com>
To: "Hiremath, Vaibhav" <hvaibhav@ti.com>
Cc: "devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Grant Likely <grant.likely@secretlab.ca>,
	Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] arm/dts: omap3-evm: Add i2c and twl4030 support
Date: Mon, 23 Jan 2012 09:56:51 +0100	[thread overview]
Message-ID: <4F1D20D3.4080307@ti.com> (raw)
In-Reply-To: <79CD15C6BA57404B839C016229A409A8317AF2E2@DBDE01.ent.ti.com>

Hi Vaibhav,

On 1/23/2012 9:49 AM, Hiremath, Vaibhav wrote:
> On Wed, Jan 18, 2012 at 12:25:39, Hiremath, Vaibhav wrote:
>> Add support for TWL4030, which is interfaced on i2c1 bus.
>> Also add clock frequencies for other i2c instances(2&  3)
>> required for client-device exist on OMAP3EVM board.
>>
>> Signed-off-by: Vaibhav Hiremath<hvaibhav@ti.com>
>> Cc: Benoit Cousson<b-cousson@ti.com>
>> Cc: Grant Likely<grant.likely@secretlab.ca>
>> Cc: Tony Lindgren<tony@atomide.com>
>> ---
>>   arch/arm/boot/dts/omap3-evm.dts |   28 ++++++++++++++++++++++++++++
>>   1 files changed, 28 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/omap3-evm.dts b/arch/arm/boot/dts/omap3-evm.dts
>> index 2eee16e..530bdc0 100644
>> --- a/arch/arm/boot/dts/omap3-evm.dts
>> +++ b/arch/arm/boot/dts/omap3-evm.dts
>> @@ -18,3 +18,31 @@
>>   		reg =<0x80000000 0x10000000>; /* 256 MB */
>>   	};
>>   };
>> +
>> +&i2c1 {
>> +	clock-frequency =<2600000>;
>> +
>> +	twl: twl@48 {
>> +		reg =<0x48>;
>> +		interrupts =<7>; /* SYS_NIRQ cascaded to intc */
>> +		interrupt-parent =<&intc>;
>> +	};
>> +};
>> +
>> +/include/ "twl4030.dtsi"
>> +
>> +&i2c2 {
>> +	clock-frequency =<400000>;
>> +};
>> +
>> +&i2c3 {
>> +	clock-frequency =<400000>;
>> +
>> +	/*
>> +	 * TVP5146 Video decoder-in for analog input support.
>> +	 */
>> +	tvp5146@5C {
>> +		compatible = "ti,tvp5146m2";
>> +		reg =<0x5C>;

Minor nit: Use lower case for hexa value.

>> +	};
>> +};
>> --
>> 1.7.0.4
>>
>>
>
> Benoit,
>
> Can this (and also AM3517 DT support patch) be merged to your
> next pull request?

Yes, assuming that Grant/Rob will ack it, I can take it.

Regards,
Benoit



      reply	other threads:[~2012-01-23  8:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-18  6:55 [PATCH] arm/dts: omap3-evm: Add i2c and twl4030 support Vaibhav Hiremath
2012-01-23  8:49 ` Hiremath, Vaibhav
2012-01-23  8:56   ` Cousson, Benoit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F1D20D3.4080307@ti.com \
    --to=b-cousson@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=hvaibhav@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).