From: Karol Lewandowski <k.lewandowsk@samsung.com>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, grant.likely@secretlab.ca,
linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
tushar.behera@linaro.org, patches@linaro.org
Subject: Re: [PATCH] gpio: samsung: adapt to changes in gpio specifier translator function declaration
Date: Wed, 01 Feb 2012 19:26:04 +0100 [thread overview]
Message-ID: <4F2983BC.40207@samsung.com> (raw)
In-Reply-To: <1328101352-22274-1-git-send-email-thomas.abraham@linaro.org>
On 01.02.2012 14:02, Thomas Abraham wrote:
> Commit 15c9a0acc3f7 (of: create of_phandle_args to simplify return of phandle
> parsing data) modifies the parameter list of of_xlate function pointer declaration
> in gpio_chip. Adapt the gpio specifier translate function for this change.
>
> Reported-by: Tushar Behera<tushar.behera@linaro.org>
> Signed-off-by: Thomas Abraham<thomas.abraham@linaro.org>
Tested-by: Karol Lewandowski <k.lewandowsk@samsung.com>
Fixes following Oops in i2c-s3c24xx.
Thanks
<1>Unable to handle kernel NULL pointer dereference at virtual address
00000000
<1>pgd = c0004000
<1>[00000000] *pgd=00000000
<0>Internal error: Oops: 5 [#1] PREEMPT SMP
<d>Modules linked in:
CPU: 0 Tainted: G W (3.3.0-rc1+ #20)
PC is at exynos4_gpio_xlate+0x18/0xe8
LR is at of_get_named_gpio_flags+0xd0/0x190
pc : [<c025dd60>] lr : [<c03423a0>] psr: 60000013
sp : e9047d88 ip : e9047da8 fp : e9047da4
r10: 00000000 r9 : 00000000 r8 : c05ecf4c
r7 : c0864ca8 r6 : 00000000 r5 : e9047db0 r4 : c025dd48
r3 : 00000004 r2 : 00000000 r1 : e9047db0 r0 : c05ecf4c
Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment kernel
Control: 10c53c7d Table: 4000404a DAC: 00000015
<0>Process swapper/0 (pid: 1, stack limit = 0xe90462f0)
<0>Stack: (0xe9047d88 to 0xe9048000)
...
[<c025dd60>] (exynos4_gpio_xlate+0x18/0xe8) from [<c03423a0>]
(of_get_named_gpio_flags+0xd0/0x190)
[<c03423a0>] (of_get_named_gpio_flags+0xd0/0x190) from [<c02e77cc>]
(s3c24xx_i2c_init+0x264/0x430)
[<c02e77cc>] (s3c24xx_i2c_init+0x264/0x430) from [<c02e7c24>]
(s3c24xx_i2c_probe+0x1c8/0x4ac)
[<c02e7c24>] (s3c24xx_i2c_probe+0x1c8/0x4ac) from [<c02a4320>]
(platform_drv_probe+0x28/0x2c)
next prev parent reply other threads:[~2012-02-01 18:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 13:02 [PATCH] gpio: samsung: adapt to changes in gpio specifier translator function declaration Thomas Abraham
2012-02-01 18:26 ` Karol Lewandowski [this message]
[not found] ` <1328101352-22274-1-git-send-email-thomas.abraham-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-02-02 0:05 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2983BC.40207@samsung.com \
--to=k.lewandowsk@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=thomas.abraham@linaro.org \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).