From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v5 08/18] tegra: fdt: Add additional USB binding Date: Thu, 02 Feb 2012 14:55:07 -0700 Message-ID: <4F2B063B.2020403@nvidia.com> References: <1327447272-30182-1-git-send-email-sjg@chromium.org> <1327447272-30182-9-git-send-email-sjg@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1327447272-30182-9-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Simon Glass Cc: Devicetree Discuss , U-Boot Mailing List , Jerry Van Baren , Tom Warren , Albert ARIBAUD List-Id: devicetree@vger.kernel.org On 01/24/2012 04:21 PM, Simon Glass wrote: > This adds a property to indicate a port which can switch between host and device > mode. ... > diff --git a/doc/device-tree-bindings/usb/tegra-usb.txt b/doc/device-tree-bindings/usb/tegra-usb.txt ... > +Optional properties: ... > + - nvidia,has-legacy-mode : boolean indicates whether this controller can > + operate in legacy mode (as APX 2500 / 2600). In legacy mode some > + registers are accessed through the APB_MISC base address instead of > + the USB controller. I was hoping to represent this as a different compatible value, in the same way as one of Tegra's I2C controllers is, eg. nvidia,tegra20-ehci and nvidia,tegra20-ehci-legacy. However, I suppose representing this using a property is OK too. Either way, can you please also push this patch to the Linux kernel (and the associated changes to tegra*.dtsi) in order to run it past the other Tegra maintainers before committing to it within U-Boot. Thanks. -- nvpublic