Re: [PATCH 1/1] gpio: drop CONFIG_OF_GPIO in the definition of the struct gpio_chip

Re: [PATCH 1/1] gpio: drop CONFIG_OF_GPIO in the definition of the struct gpio_chip

[Nicolas Ferre]

On 02/13/2012 10:23 AM, Jean-Christophe PLAGNIOL-VILLARD :
> this will allow to avoid the ifdef CONFIG_OF_GPIO in gpio drivers
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
> Cc: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
> Cc: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>

Added devicetree-discuss ml.

> ---
>  include/asm-generic/gpio.h |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/include/asm-generic/gpio.h b/include/asm-generic/gpio.h
> index 1ff4e22..c08b758 100644
> --- a/include/asm-generic/gpio.h
> +++ b/include/asm-generic/gpio.h
> @@ -122,7 +122,6 @@ struct gpio_chip {
>  	unsigned		can_sleep:1;
>  	unsigned		exported:1;
>  
> -#if defined(CONFIG_OF_GPIO)
>  	/*
>  	 * If CONFIG_OF is enabled, then all GPIO controllers described in the

Maybe you will need to rework this comment.

>  	 * device tree automatically may have an OF translation
> @@ -131,7 +130,6 @@ struct gpio_chip {
>  	int of_gpio_n_cells;
>  	int (*of_xlate)(struct gpio_chip *gc,
>  		        const struct of_phandle_args *gpiospec, u32 *flags);
> -#endif

I do not know if we can remove the ifdef completely of just move of_node
out of it.


>  };
>  
>  extern const char *gpiochip_is_requested(struct gpio_chip *chip,


-- 
Nicolas Ferre

Re: [PATCH 1/1] gpio: drop CONFIG_OF_GPIO in the definition of the struct gpio_chip

[Jean-Christophe PLAGNIOL-VILLARD]

On 11:18 Mon 13 Feb     , Nicolas Ferre wrote:
> On 02/13/2012 10:23 AM, Jean-Christophe PLAGNIOL-VILLARD :
> > this will allow to avoid the ifdef CONFIG_OF_GPIO in gpio drivers
> > 
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> 
> Added devicetree-discuss ml.
> 
> > ---
> >  include/asm-generic/gpio.h |    2 --
> >  1 files changed, 0 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/asm-generic/gpio.h b/include/asm-generic/gpio.h
> > index 1ff4e22..c08b758 100644
> > --- a/include/asm-generic/gpio.h
> > +++ b/include/asm-generic/gpio.h
> > @@ -122,7 +122,6 @@ struct gpio_chip {
> >  	unsigned		can_sleep:1;
> >  	unsigned		exported:1;
> >  
> > -#if defined(CONFIG_OF_GPIO)
> >  	/*
> >  	 * If CONFIG_OF is enabled, then all GPIO controllers described in the
> 
> Maybe you will need to rework this comment.
> 
> >  	 * device tree automatically may have an OF translation
> > @@ -131,7 +130,6 @@ struct gpio_chip {
> >  	int of_gpio_n_cells;
> >  	int (*of_xlate)(struct gpio_chip *gc,
> >  		        const struct of_phandle_args *gpiospec, u32 *flags);
> > -#endif
> 
> I do not know if we can remove the ifdef completely of just move of_node
> out of it.
basicaly ifdef on a struct is so so
so yes

Best Regards,
J.