From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Cousson, Benoit" Subject: Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver Date: Wed, 22 Feb 2012 15:31:19 +0100 Message-ID: <4F44FC37.2000701@ti.com> References: <1329321854-24490-1-git-send-email-b-cousson@ti.com> <1329321854-24490-4-git-send-email-b-cousson@ti.com> <4F44FA56.7020000@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F44FA56.7020000@gmail.com> Sender: linux-omap-owner@vger.kernel.org To: Rob Herring Cc: grant.likely@secretlab.ca, khilman@ti.com, devicetree-discuss@lists.ozlabs.org, linux-omap@vger.kernel.org, Tarun Kanti DebBarma , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 2/22/2012 3:23 PM, Rob Herring wrote: > On 02/15/2012 10:04 AM, Benoit Cousson wrote: >> Adapt the GPIO driver to retrieve information from a DT file. >> >> Allocate the irq_base dynamically and rename bank->virtual_irq_start >> to bank->irq_base. >> Change irq_base type to int instead of u16 to match irq_alloc_descs >> output. >> >> Add documentation for GPIO properties specific to OMAP. >> >> Signed-off-by: Benoit Cousson >> Cc: Tarun Kanti DebBarma > > One comment below, but otherwise: > > Acked-by: Rob Herring > >> --- >> .../devicetree/bindings/gpio/gpio-omap.txt | 30 +++++ >> drivers/gpio/gpio-omap.c | 121 ++++++++++++++++++-- >> 2 files changed, 142 insertions(+), 9 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-omap.txt >> >> diff --git a/Documentation/devicetree/bindings/gpio/gpio-omap.txt b/Documentation/devicetree/bindings/gpio/gpio-omap.txt >> new file mode 100644 >> index 0000000..c1b3100 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/gpio/gpio-omap.txt >> @@ -0,0 +1,30 @@ >> +OMAP GPIO controller bindings >> + >> +Required properties: >> +- compatible: >> + - "ti,omap2-gpio" for OMAP2 controllers >> + - "ti,omap3-gpio" for OMAP3 controllers >> + - "ti,omap4-gpio" for OMAP4 controllers >> +- #gpio-cells : Should be two. >> + - first cell is the pin number >> + - second cell is used to specify optional parameters (unused) >> +- gpio-controller : Marks the device node as a GPIO controller. >> +- #interrupt-cells : Should be one > > There's no level/edge settings for gpios? That's a good question, because I was wondering as well :-) I did no see how it was done in other GPIO implementation. Benoit