From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 11/11] ARM: tegra: pcie: Add device tree support Date: Thu, 08 Mar 2012 14:31:41 -0700 Message-ID: <4F59253D.7070100@wwwdotorg.org> References: <1331218291-16119-1-git-send-email-thierry.reding@avionic-design.de> <1331218291-16119-12-git-send-email-thierry.reding@avionic-design.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1331218291-16119-12-git-send-email-thierry.reding@avionic-design.de> Sender: linux-pci-owner@vger.kernel.org To: Thierry Reding , Liam Girdwood , Mark Brown Cc: linux-tegra@vger.kernel.org, Jesse Barnes , linux-pci@vger.kernel.org, Grant Likely , Rob Herring , devicetree-discuss@lists.ozlabs.org, Russell King , linux-arm-kernel@lists.infradead.org, Colin Cross , Olof Johansson List-Id: devicetree@vger.kernel.org On 03/08/2012 07:51 AM, Thierry Reding wrote: > This commit adds support for instantiating the Tegra PCIe controller > from a device tree. > > Signed-off-by: Thierry Reding > diff --git a/Documentation/devicetree/bindings/pci/tegra-pcie.txt b/Documentation/devicetree/bindings/pci/tegra-pcie.txt > +NVIDIA Tegra PCIe controller > + > +Required properties: > +- compatible: "nvidia,tegra20-pcie" > +- reg: physical base address and length of the controller's registers > +- interrupts: the interrupt outputs of the controller > + > +Optional properties: > +- pex-clk-supply: supply voltage for internal reference clock > +- vdd-supply: power supply for controller (1.05V) Mark, Liam, Should those *-supply properties really be optional? I got the impression talking to Mark in a different thread that all regulators should exist, although their implementation may be via a fixed regulator, with no GPIO, as determined by the board design.