From: Rob Herring <robherring2@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: b29396@freescale.com, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] of: add NULL parameter check for of_device_is_available
Date: Tue, 13 Mar 2012 16:15:20 -0500 [thread overview]
Message-ID: <4F5FB8E8.7010102@gmail.com> (raw)
In-Reply-To: <20120313.133419.2242081944811028058.davem@davemloft.net>
On 03/13/2012 03:34 PM, David Miller wrote:
> From: Dong Aisheng <b29396@freescale.com>
> Date: Tue, 13 Mar 2012 19:40:05 +0800
>
>> From: Dong Aisheng <dong.aisheng@linaro.org>
>>
>> This function will return 1 even the device node passed in
>> is NULL which is a little error-prone.
>> Change to return 0 if the device node passed in is NULL.
>>
>> Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
>
> I think this is a hard error and therefore BUG_ON(!device) is
> more appropriate.
Shouldn't removing a node from the dts and adding 'status = "disabled";'
to a node give the same behavior? Then you can do something like this:
if (of_device_is_available(of_find_compatible_node("blah")))
//foo
Rob
prev parent reply other threads:[~2012-03-13 21:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 11:40 [PATCH 1/1] of: add NULL parameter check for of_device_is_available Dong Aisheng
2012-03-13 12:46 ` Rob Herring
2012-03-13 20:34 ` David Miller
2012-03-13 21:15 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5FB8E8.7010102@gmail.com \
--to=robherring2@gmail.com \
--cc=b29396@freescale.com \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).