From: Rob Herring <robherring2@gmail.com>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: devicetree-discuss@lists.ozlabs.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
patches@linaro.org
Subject: Re: [PATCH] of/irq: add empty irq_of_parse_and_map() for non-dt builds
Date: Sat, 24 Mar 2012 08:18:05 -0500 [thread overview]
Message-ID: <4F6DC98D.9040800@gmail.com> (raw)
In-Reply-To: <4F6DC847.8000902@gmail.com>
On 03/24/2012 08:12 AM, Rob Herring wrote:
> On 03/24/2012 04:27 AM, Thomas Abraham wrote:
>> Add a empty irq_of_parse_and_map() that returns 0 for non-dt builds and
>> avoid having #ifdef CONFIG_OF around all calls to irq_of_parse_and_map().
>>
>> Suggested-by: Grant Likely <grant.likely@secretlab.ca>
>> Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org>
>> ---
>
> Acked-by: Rob Herring <rob.herring@calxeda.com>
>
> Go ahead and merge with the rest of your series.
>
Screwed up the lkml address, so just adding it back...
Rob
> Rob
>
>> include/linux/of_irq.h | 6 ++++++
>> 1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/linux/of_irq.h b/include/linux/of_irq.h
>> index d229ad3..5614355 100644
>> --- a/include/linux/of_irq.h
>> +++ b/include/linux/of_irq.h
>> @@ -76,5 +76,11 @@ extern struct device_node *of_irq_find_parent(struct device_node *child);
>> extern void of_irq_init(const struct of_device_id *matches);
>>
>> #endif /* CONFIG_OF_IRQ */
>> +#else /* CONFIG_OF */
>> +static inline unsigned int irq_of_parse_and_map(struct device_node *dev,
>> + int index)
>> +{
>> + return 0;
>> +}
>> #endif /* CONFIG_OF */
>> #endif /* __OF_IRQ_H */
>
next prev parent reply other threads:[~2012-03-24 13:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-24 9:27 [PATCH] of/irq: add empty irq_of_parse_and_map() for non-dt builds Thomas Abraham
[not found] ` <1332581257-15989-1-git-send-email-thomas.abraham-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-03-24 13:12 ` Rob Herring
2012-03-24 13:18 ` Rob Herring [this message]
[not found] ` <4F6DC847.8000902-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-03-24 16:07 ` Thomas Abraham
2012-03-24 16:12 ` Thomas Abraham
[not found] ` <CAJuYYwQfNNO94_9nQnXH3xEoP6aWSJi4Hcpuh82N2xfGKJ4OnA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-25 0:43 ` Grant Likely
2012-03-25 0:42 ` Grant Likely
2012-03-25 14:56 ` Thomas Abraham
2012-03-27 22:28 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6DC98D.9040800@gmail.com \
--to=robherring2@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).