devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH V2] dtc: Basic integer expressions
Date: Mon, 02 Apr 2012 10:16:27 -0600	[thread overview]
Message-ID: <4F79D0DB.9010500@wwwdotorg.org> (raw)
In-Reply-To: <E1SDzDw-0003C1-Ag-CYoMK+44s/E@public.gmane.org>

On 03/31/2012 08:24 AM, Jon Loeliger wrote:
>> Written by David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>. Additions by me:
>> * Ported to ToT dtc.
>> * Renamed cell to integer throughout.
>> * Implemented value range checks.
>> * Allow L/UL/LL/ULL suffix on literals.
>> * Enabled the commented test.
>>
>> Signed-off-by: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
>> ---
>> v2:
>> * s/cell/integer/ throughout.
>> * Allow signed-extended values to pass the overall cell range check.
>> * Allow L/UL/LL/ULL suffix on literals. This is purely for compatibility
>>   with C, and has no effect on dtc's processing.
>> * Enabled the 3 disabled tests.
>>
>> I'm not sure if the literal suffix handling is hacky or not...
> 
> I get this too:
> 
>  CC tests/integer-expressions.o
> cc1: warnings being treated as errors
> tests/integer-expressions.c: In function 'main'
> tests/integer-expressions.c:105: error: format  tests/integer-expressions.o
> cc1: warnings being treated as errors
> tests/integer-expressions.c:105: error: format '%ld' expects type 'long int', but argument 3 has type 'unsigned int'
> make: *** [tests/integer-expressions.o] Error 1
> 
> $ gcc --version
> gcc (Debian 4.4.5-8) 4.4.5

I assume this is a 32-bit system? I guess I can use <inttypes.h> to
solve this if needed.

  parent reply	other threads:[~2012-04-02 16:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-28  2:24 [PATCH V2] dtc: Basic integer expressions Stephen Warren
     [not found] ` <1332901483-3751-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-31 14:24   ` Jon Loeliger
     [not found]     ` <E1SDzDw-0003C1-Ag-CYoMK+44s/E@public.gmane.org>
2012-04-02 16:16       ` Stephen Warren [this message]
     [not found]         ` <4F79D0DB.9010500-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-03 23:12           ` David Gibson
2012-04-04  0:04   ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F79D0DB.9010500@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=jdl-CYoMK+44s/E@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).